[SPARK-22049][DOCS] Confusing behavior of from_utc_timestamp and to_utc_timestamp #19276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
CC @HyukjinKwon as I think we talked about this a long time ago |
|
Test build #81918 has finished for PR 19276 at commit
|
|
Test build #81919 has finished for PR 19276 at commit
|
HyukjinKwon
reviewed
Sep 19, 2017
R/pkg/R/functions.R
Outdated
| #' @details | ||
| #' \code{from_utc_timestamp}: Given a timestamp, which corresponds to a certain time of day in UTC, | ||
| #' returns another timestamp that corresponds to the same time of day in the given timezone. | ||
| #' \code{from_utc_timestamp}: Given a timestamp like '2017-07-14 02:40:00.0', interprets it as a time in UTC, and |
Member
There was a problem hiding this comment.
I think lintr does not recognise this case but I believe these lines should fit in 100 character lengths ..
Member
|
LGTM |
|
Test build #81920 has finished for PR 19276 at commit
|
HyukjinKwon
reviewed
Sep 19, 2017
R/pkg/R/functions.R
Outdated
| #' \code{from_utc_timestamp}: Given a timestamp, which corresponds to a certain time of day in UTC, | ||
| #' returns another timestamp that corresponds to the same time of day in the given timezone. | ||
| #' \code{from_utc_timestamp}: Given a timestamp like '2017-07-14 02:40:00.0', interprets it as a time in UTC, and | ||
| # renders that time as a timestamp in the given time zone. For example, 'GMT+1' would yield '2017-07-14 03:40:00.0'. |
Member
There was a problem hiding this comment.
Oh, and missing #' at the beginning.
felixcheung
reviewed
Sep 20, 2017
R/pkg/R/functions.R
Outdated
| #' \code{to_utc_timestamp}: Given a timestamp, which corresponds to a certain time of day | ||
| #' in the given timezone, returns another timestamp that corresponds to the same time of day in UTC. | ||
| #' \code{to_utc_timestamp}: Given a timestamp like '2017-07-14 02:40:00.0', interprets it as a time in the given | ||
| # time zone, and renders that time as a timestamp in UTC. For example, 'GMT+1' would yield '2017-07-14 01:40:00.0'. |
|
Test build #81983 has finished for PR 19276 at commit
|
Member
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Clarify behavior of to_utc_timestamp/from_utc_timestamp with an example
How was this patch tested?
Doc only change / existing tests