Skip to content

Conversation

@davies
Copy link
Contributor

@davies davies commented Aug 13, 2014

because Pyrolite does not support array from Python 2.6

because Pyrolite does not support array from Python2.6
@SparkQA
Copy link

SparkQA commented Aug 13, 2014

QA tests have started for PR 1928. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18455/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 13, 2014

QA results for PR 1928:
- This patch FAILED unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18455/consoleFull

@marmbrus
Copy link
Contributor

test this please

@davies
Copy link
Contributor Author

davies commented Aug 13, 2014

jenkins, test this please

@SparkQA
Copy link

SparkQA commented Aug 13, 2014

QA tests have started for PR 1928. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18463/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 13, 2014

QA results for PR 1928:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18463/consoleFull

@marmbrus
Copy link
Contributor

Thanks! I've merge this into master and 1.1

@asfgit asfgit closed this in c974a71 Aug 13, 2014
asfgit pushed a commit that referenced this pull request Aug 13, 2014
because Pyrolite does not support array from Python 2.6

Author: Davies Liu <[email protected]>

Closes #1928 from davies/fix_array and squashes the following commits:

858e6c5 [Davies Liu] convert array into list

(cherry picked from commit c974a71)
Signed-off-by: Michael Armbrust <[email protected]>
@kanzhang
Copy link
Contributor

Now that I think about it, our WritableToJavaConverter should probably convert array to java collection (which gets pickled to Python list), instead of Object[] (which gets picked to Python tuple), as it is now.

@davies
Copy link
Contributor Author

davies commented Aug 15, 2014

@kanzhang I think either way is fine, tuple is like read-only list. RDD is read only, so there is no difference between having list or tuple in RDD.

@kanzhang
Copy link
Contributor

@davies that's true. One thing I like about Python list is that it gets mapped to Java List (symmetry). However, it's not array any more.

xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
because Pyrolite does not support array from Python 2.6

Author: Davies Liu <[email protected]>

Closes apache#1928 from davies/fix_array and squashes the following commits:

858e6c5 [Davies Liu] convert array into list
@davies davies deleted the fix_array branch September 15, 2014 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants