[SPARK-22066][BUILD] Update checkstyle to 8.2, enable it, fix violations #19282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate checkstyle to 8.2. Remove bogus checkstyle config and enable it. Fix existing and new Java checkstyle errors.
|
Test build #81948 has finished for PR 19282 at commit
|
Member
Author
|
Merged to master |
srowen
added a commit
to srowen/spark
that referenced
this pull request
Sep 20, 2017
## What changes were proposed in this pull request? Update plugins, including scala-maven-plugin, to latest versions. Update checkstyle to 8.2. Remove bogus checkstyle config and enable it. Fix existing and new Java checkstyle errors. ## How was this patch tested? Existing tests Author: Sean Owen <[email protected]> Closes apache#19282 from srowen/SPARK-22066.
srowen
commented
Sep 20, 2017
| <groupId>net.alchim31.maven</groupId> | ||
| <artifactId>scala-maven-plugin</artifactId> | ||
| <version>3.2.2</version> | ||
| <version>3.3.1</version> |
Member
Author
There was a problem hiding this comment.
Darn, this seems to cause a failure when Maven and zinc are used, only -- can't find javac because it looks in a JRE directory. I'll revert this if I can't see an immediate solution. that's why it wasn't caught by me or the PR builder, I think.
Member
Author
There was a problem hiding this comment.
No easy solution; related to davidB/scala-maven-plugin#161 I'm reverting this part of the change.
srowen
added a commit
to srowen/spark
that referenced
this pull request
Sep 20, 2017
…rk with Maven+zinc again ## What changes were proposed in this pull request? See apache#19282 Revert scala-maven-plugin to 3.2.2 to work with Maven+zinc again ## How was this patch tested? Reproduced locally with zinc, and confirmed this removes the problem. Author: Sean Owen <[email protected]> Closes apache#19292 from srowen/SPARK-22066.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Update plugins, including scala-maven-plugin, to latest versions. Update checkstyle to 8.2. Remove bogus checkstyle config and enable it. Fix existing and new Java checkstyle errors.
How was this patch tested?
Existing tests