Skip to content

[SPARK-22126][ML][WIP] Fix model-specific optimization support for ML tuning #19350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WeichenXu123 wants to merge 3 commits into from
Closed

[SPARK-22126][ML][WIP] Fix model-specific optimization support for ML tuning #19350

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d5625a6
init pr
WeichenXu123 Sep 26, 2017
5614390
update & resolve conflicts
WeichenXu123 Nov 15, 2017
1b4a384
add java api
WeichenXu123 Nov 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update & resolve conflicts
  • Loading branch information
@WeichenXu123
WeichenXu123 committed Nov 15, 2017
commit 56143905f23f83b1c130fbbe42ef48fe3a5c1b2d
3 changes: 3 additions & 0 deletions mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,9 @@ class CrossValidator @Since("1.2.0") (@Since("1.4.0") override val uid: String)
val foldMetrics = new Array[Double](epm.length)
est.fit(trainingDataset, epm, true, executionContext,
(model: Model[_], paramMap: ParamMap, paramMapIndex: Int) => {
if (collectSubModelsParam) {
subModels.get(splitIndex)(paramMapIndex) = model
}
// TODO: duplicate evaluator to take extra params from input
val metric = eval.evaluate(model.transform(validationDataset, paramMap))
logDebug(s"Got metric $metric for model trained with $paramMap.")
Expand Down
3 changes: 3 additions & 0 deletions mllib/src/main/scala/org/apache/spark/ml/tuning/TrainValidationSplit.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,9 @@ class TrainValidationSplit @Since("1.5.0") (@Since("1.5.0") override val uid: St
val metrics = new Array[Double](epm.length)
est.fit(trainingDataset, epm, true, executionContext,
(model: Model[_], paramMap: ParamMap, paramMapIndex: Int) => {
if (collectSubModelsParam) {
subModels.get(paramMapIndex) = model
}
// TODO: duplicate evaluator to take extra params from input
val metric = eval.evaluate(model.transform(validationDataset, paramMap))
logDebug(s"Got metric $metric for model trained with $paramMap.")
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.