Skip to content

[SPARK-22372][core, yarn] Make cluster submission use SparkApplication. #19631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vanzin wants to merge 11 commits into from
Closed

[SPARK-22372][core, yarn] Make cluster submission use SparkApplication. #19631

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c80554b
[SPARK-22372][core, yarn] Make cluster submission use SparkApplication.
Oct 30, 2017
cee6be2
Add mima excludes.
Nov 1, 2017
cb6c8ff
Remove stale comment.
Nov 7, 2017
593eb6b
Rename constants.
Nov 14, 2017
121bcf8
Correctly filter out SPARK_AUTH_SECRET_CONF.
Nov 15, 2017
08f47ca
Cleanup SPARK_YARN_MODE in tests.
Nov 15, 2017
2129ccb
Propagate secret to executors from AM to avoid writing it to disk.
Nov 16, 2017
86f0bf8
Unbreak test.
Nov 16, 2017
e8dc7ec
Merge branch 'master' into SPARK-22372
Nov 30, 2017
515f8f8
Feedback.
Nov 30, 2017
c752453
Go back to propagating secret using credentials.
Dec 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add mima excludes. 
SparkHadoopUtil is not documented as a public class in Spark's API
docs, so just added new exclusions.
  • Loading branch information
Marcelo Vanzin committed Nov 1, 2017
commit cee6be231310b89d35d5b419bd30153f29dd4cb9
6 changes: 6 additions & 0 deletions project/MimaExcludes.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,12 @@ object MimaExcludes {

// Exclude rules for 2.3.x
lazy val v23excludes = v22excludes ++ Seq(
// SPARK-22372: Make cluster submission use SparkApplication.
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.deploy.SparkHadoopUtil.getSecretKeyFromUserCredentials"),
Copy link
Contributor

@tgravescs tgravescs Dec 1, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This overall change is only going into spark 2.3 ? Wondering for compatibility. I realize this is developerapi but would be nice to not change in minor release I think.

Copy link
Contributor Author

@vanzin vanzin Dec 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is 2.3 only.

I've always questioned why SparkHadoopUtil is public in the first place. I'm not that worried about removing the functionality in this method because Spark apps don't really need to depend on it; it's easy to call the Hadoop API directly, and the API did nothing before except in YARN mode.

ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.deploy.SparkHadoopUtil.isYarnMode"),
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.deploy.SparkHadoopUtil.getCurrentUserCredentials"),
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.deploy.SparkHadoopUtil.addSecretKeyToUserCredentials"),

// SPARK-18085: Better History Server scalability for many / large applications
ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.status.api.v1.ExecutorSummary.executorLogs"),
// [SPARK-20495][SQL] Add StorageLevel to cacheTable API
Expand Down