[SPARK-3081][MLLIB] rename RandomRDDGenerators to RandomRDDs#1979
Closed
mengxr wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-3081][MLLIB] rename RandomRDDGenerators to RandomRDDs#1979mengxr wants to merge 1 commit intoapache:masterfrom
mengxr wants to merge 1 commit intoapache:masterfrom
Conversation
|
QA tests have started for PR 1979 at commit
|
|
QA tests have finished for PR 1979 at commit
|
Contributor
|
It's a shorter name, and I understand the concern about the confusion. Looks good to me! |
Contributor
Author
|
@brkyvz Thanks for reviewing! I've merged this into master and branch-1.1. |
asfgit
pushed a commit
that referenced
this pull request
Aug 16, 2014
`RandomRDDGenerators` means factory for `RandomRDDGenerator`. However, its methods return RDDs but not RDDGenerators. So a more proper (and shorter) name would be `RandomRDDs`. dorx brkyvz Author: Xiangrui Meng <meng@databricks.com> Closes #1979 from mengxr/randomrdds and squashes the following commits: b161a2d [Xiangrui Meng] rename RandomRDDGenerators to RandomRDDs (cherry picked from commit ac6411c) Signed-off-by: Xiangrui Meng <meng@databricks.com>
xiliu82
pushed a commit
to xiliu82/spark
that referenced
this pull request
Sep 4, 2014
`RandomRDDGenerators` means factory for `RandomRDDGenerator`. However, its methods return RDDs but not RDDGenerators. So a more proper (and shorter) name would be `RandomRDDs`. dorx brkyvz Author: Xiangrui Meng <meng@databricks.com> Closes apache#1979 from mengxr/randomrdds and squashes the following commits: b161a2d [Xiangrui Meng] rename RandomRDDGenerators to RandomRDDs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RandomRDDGeneratorsmeans factory forRandomRDDGenerator. However, its methods return RDDs but not RDDGenerators. So a more proper (and shorter) name would beRandomRDDs.@dorx @brkyvz