Skip to content

[SPARK-22570][SQL] Avoid to create a lot of global variables by using a local variable with allocation of an object in generated code #19797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kiszk wants to merge 12 commits into from
Closed

[SPARK-22570][SQL] Avoid to create a lot of global variables by using a local variable with allocation of an object in generated code #19797

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
41a591a
initial commit for cast
kiszk Nov 22, 2017
de5cd38
initial commit for regexpreplace
kiszk Nov 22, 2017
1046e1d
createarray
kiszk Nov 22, 2017
13e05b7
fix scala style error
kiszk Nov 22, 2017
072cdd2
fix conflict of variable names
kiszk Nov 23, 2017
d4e4b07
address review comments
kiszk Nov 23, 2017
36a330d
address review comments
kiszk Nov 29, 2017
3b8459d
fix test failure of HiveThriftBinaryServerSuite.SPARK-4407
kiszk Nov 30, 2017
420b10d
fix test failure of HiveThriftBinaryServerSuite.SPARK-4407
kiszk Nov 30, 2017
cd4c696
clear object pointer at the end of lifetime to avoid unnecessary GC
kiszk Nov 30, 2017
a455ac3
address review comments
kiszk Nov 30, 2017
747e215
address review comments
kiszk Nov 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clear object pointer at the end of lifetime to avoid unnecessary GC
  • Loading branch information
@kiszk
kiszk committed Nov 30, 2017
commit cd4c696772750e6e9b79133446e590bc65a24ce4
4 changes: 4 additions & 0 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,6 +808,7 @@ case class Cast(child: Expression, dataType: DataType, timeZoneId: Option[String
} else {
$evNull = true;
}
$wrapper = null;
"""
case BooleanType =>
(c, evPrim, evNull) => s"$evPrim = $c ? (byte) 1 : (byte) 0;"
Expand All @@ -834,6 +835,7 @@ case class Cast(child: Expression, dataType: DataType, timeZoneId: Option[String
} else {
$evNull = true;
}
$wrapper = null;
"""
case BooleanType =>
(c, evPrim, evNull) => s"$evPrim = $c ? (short) 1 : (short) 0;"
Expand All @@ -858,6 +860,7 @@ case class Cast(child: Expression, dataType: DataType, timeZoneId: Option[String
} else {
$evNull = true;
}
$wrapper = null;
"""
case BooleanType =>
(c, evPrim, evNull) => s"$evPrim = $c ? 1 : 0;"
Expand All @@ -883,6 +886,7 @@ case class Cast(child: Expression, dataType: DataType, timeZoneId: Option[String
} else {
$evNull = true;
}
$wrapper = null;
"""
case BooleanType =>
(c, evPrim, evNull) => s"$evPrim = $c ? 1L : 0L;"
Expand Down