-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-18016][SQL] Code Generation: Constant Pool Limit - reduce entries for mutable state #19811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
d441794
update API of addMutableState
kiszk 870d106
eliminate initialization with default value
kiszk 24d7087
allocate a global Java array to store a lot of mutable state in a class
kiszk 3eb5842
fix scala style error
kiszk 074d711
fix test failure of ExpressionEncoderSuite.NestedArray
kiszk eafa3f8
rebase with master
kiszk 90d15f3
address review comments
kiszk c456c07
add useFreshname parameter to addMutableState
kiszk 9ca5ab3
rebase with master
kiszk 5b36c61
fix test failures
kiszk fd51d75
drop to creat a loop for initialization
kiszk effe918
fix test failure
kiszk 9df109c
update comments
kiszk 634d494
address review comment
kiszk d3438fd
address review comment
kiszk f4f3754
address review comment
kiszk f1e1fca
address review comments except test case
kiszk 0937ef2
rebase with master
kiszk 4bfcc1a
Do not use compaction as possible for frequently-accessed variable
kiszk 49119a9
exclude mutable state from argument list for ExpressionCodegn
kiszk 24f49c5
fix test failures
kiszk 15e967e
address review comments
kiszk d6c1a97
address review comments
kiszk a9d40e9
address review comments
kiszk 31914c0
address review comments
kiszk 0e45c19
address review comments
kiszk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
address review comment
- Loading branch information
commit d3438fd4a969dc98032d3c89efeff6cdd214200c
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto