Skip to content

[SPARK-22762][TEST] Basic tests for IfCoercion and CaseWhenCoercion #19949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wangyum wants to merge 2 commits into from
Closed

[SPARK-22762][TEST] Basic tests for IfCoercion and CaseWhenCoercion #19949

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9da910
Basic tests for IfCoercion and CaseWhenCoercion
wangyum Dec 12, 2017
8d04720
Remove short
wangyum Dec 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove short
  • Loading branch information
@wangyum
wangyum committed Dec 15, 2017
commit 8d0472034e9267f7a6758b2ee9527f226e8f823e
26 changes: 0 additions & 26 deletions sql/core/src/test/resources/sql-tests/inputs/typeCoercion/native/caseWhenCoercion.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ CREATE TEMPORARY VIEW t AS SELECT 1;

SELECT CASE WHEN true THEN cast(1 as tinyint) ELSE cast(2 as tinyint) END FROM t;
Copy link
Member

@gatorsmile gatorsmile Dec 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to confirm whether these queries you added can be executed in Hive?

Copy link
Member Author

@wangyum wangyum Dec 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gatorsmile Two questions:

  1. Hive doesn't have the short type, so can we remove the short type here?
  2. Hive can't execute CREATE TEMPORARY VIEW ..., but can executor CREATE TEMPORARY TABLE ..., Do we add this feature to spark?

Copy link
Member

@gatorsmile gatorsmile Dec 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, we might do it for supporting the actual TEMP table.

Yeah, please get rid of short.

SELECT CASE WHEN true THEN cast(1 as tinyint) ELSE cast(2 as smallint) END FROM t;
SELECT CASE WHEN true THEN cast(1 as tinyint) ELSE cast(2 as short) END FROM t;
SELECT CASE WHEN true THEN cast(1 as tinyint) ELSE cast(2 as int) END FROM t;
SELECT CASE WHEN true THEN cast(1 as tinyint) ELSE cast(2 as bigint) END FROM t;
SELECT CASE WHEN true THEN cast(1 as tinyint) ELSE cast(2 as float) END FROM t;
Expand All @@ -33,7 +32,6 @@ SELECT CASE WHEN true THEN cast(1 as tinyint) ELSE cast('2017-12-11 09:30:00' as

SELECT CASE WHEN true THEN cast(1 as smallint) ELSE cast(2 as tinyint) END FROM t;
SELECT CASE WHEN true THEN cast(1 as smallint) ELSE cast(2 as smallint) END FROM t;
SELECT CASE WHEN true THEN cast(1 as smallint) ELSE cast(2 as short) END FROM t;
SELECT CASE WHEN true THEN cast(1 as smallint) ELSE cast(2 as int) END FROM t;
SELECT CASE WHEN true THEN cast(1 as smallint) ELSE cast(2 as bigint) END FROM t;
SELECT CASE WHEN true THEN cast(1 as smallint) ELSE cast(2 as float) END FROM t;
Expand All @@ -45,23 +43,8 @@ SELECT CASE WHEN true THEN cast(1 as smallint) ELSE cast(2 as boolean) END FROM
SELECT CASE WHEN true THEN cast(1 as smallint) ELSE cast('2017-12-11 09:30:00.0' as timestamp) END FROM t;
SELECT CASE WHEN true THEN cast(1 as smallint) ELSE cast('2017-12-11 09:30:00' as date) END FROM t;

SELECT CASE WHEN true THEN cast(1 as short) ELSE cast(2 as tinyint) END FROM t;
SELECT CASE WHEN true THEN cast(1 as short) ELSE cast(2 as smallint) END FROM t;
SELECT CASE WHEN true THEN cast(1 as short) ELSE cast(2 as short) END FROM t;
SELECT CASE WHEN true THEN cast(1 as short) ELSE cast(2 as int) END FROM t;
SELECT CASE WHEN true THEN cast(1 as short) ELSE cast(2 as bigint) END FROM t;
SELECT CASE WHEN true THEN cast(1 as short) ELSE cast(2 as float) END FROM t;
SELECT CASE WHEN true THEN cast(1 as short) ELSE cast(2 as double) END FROM t;
SELECT CASE WHEN true THEN cast(1 as short) ELSE cast(2 as decimal(10, 0)) END FROM t;
SELECT CASE WHEN true THEN cast(1 as short) ELSE cast(2 as string) END FROM t;
SELECT CASE WHEN true THEN cast(1 as short) ELSE cast('2' as binary) END FROM t;
SELECT CASE WHEN true THEN cast(1 as short) ELSE cast(2 as boolean) END FROM t;
SELECT CASE WHEN true THEN cast(1 as short) ELSE cast('2017-12-11 09:30:00.0' as timestamp) END FROM t;
SELECT CASE WHEN true THEN cast(1 as short) ELSE cast('2017-12-11 09:30:00' as date) END FROM t;

SELECT CASE WHEN true THEN cast(1 as int) ELSE cast(2 as tinyint) END FROM t;
SELECT CASE WHEN true THEN cast(1 as int) ELSE cast(2 as smallint) END FROM t;
SELECT CASE WHEN true THEN cast(1 as int) ELSE cast(2 as short) END FROM t;
SELECT CASE WHEN true THEN cast(1 as int) ELSE cast(2 as int) END FROM t;
SELECT CASE WHEN true THEN cast(1 as int) ELSE cast(2 as bigint) END FROM t;
SELECT CASE WHEN true THEN cast(1 as int) ELSE cast(2 as float) END FROM t;
Expand All @@ -75,7 +58,6 @@ SELECT CASE WHEN true THEN cast(1 as int) ELSE cast('2017-12-11 09:30:00' as dat

SELECT CASE WHEN true THEN cast(1 as bigint) ELSE cast(2 as tinyint) END FROM t;
SELECT CASE WHEN true THEN cast(1 as bigint) ELSE cast(2 as smallint) END FROM t;
SELECT CASE WHEN true THEN cast(1 as bigint) ELSE cast(2 as short) END FROM t;
SELECT CASE WHEN true THEN cast(1 as bigint) ELSE cast(2 as int) END FROM t;
SELECT CASE WHEN true THEN cast(1 as bigint) ELSE cast(2 as bigint) END FROM t;
SELECT CASE WHEN true THEN cast(1 as bigint) ELSE cast(2 as float) END FROM t;
Expand All @@ -89,7 +71,6 @@ SELECT CASE WHEN true THEN cast(1 as bigint) ELSE cast('2017-12-11 09:30:00' as

SELECT CASE WHEN true THEN cast(1 as float) ELSE cast(2 as tinyint) END FROM t;
SELECT CASE WHEN true THEN cast(1 as float) ELSE cast(2 as smallint) END FROM t;
SELECT CASE WHEN true THEN cast(1 as float) ELSE cast(2 as short) END FROM t;
SELECT CASE WHEN true THEN cast(1 as float) ELSE cast(2 as int) END FROM t;
SELECT CASE WHEN true THEN cast(1 as float) ELSE cast(2 as bigint) END FROM t;
SELECT CASE WHEN true THEN cast(1 as float) ELSE cast(2 as float) END FROM t;
Expand All @@ -103,7 +84,6 @@ SELECT CASE WHEN true THEN cast(1 as float) ELSE cast('2017-12-11 09:30:00' as d

SELECT CASE WHEN true THEN cast(1 as double) ELSE cast(2 as tinyint) END FROM t;
SELECT CASE WHEN true THEN cast(1 as double) ELSE cast(2 as smallint) END FROM t;
SELECT CASE WHEN true THEN cast(1 as double) ELSE cast(2 as short) END FROM t;
SELECT CASE WHEN true THEN cast(1 as double) ELSE cast(2 as int) END FROM t;
SELECT CASE WHEN true THEN cast(1 as double) ELSE cast(2 as bigint) END FROM t;
SELECT CASE WHEN true THEN cast(1 as double) ELSE cast(2 as float) END FROM t;
Expand All @@ -117,7 +97,6 @@ SELECT CASE WHEN true THEN cast(1 as double) ELSE cast('2017-12-11 09:30:00' as

SELECT CASE WHEN true THEN cast(1 as decimal(10, 0)) ELSE cast(2 as tinyint) END FROM t;
SELECT CASE WHEN true THEN cast(1 as decimal(10, 0)) ELSE cast(2 as smallint) END FROM t;
SELECT CASE WHEN true THEN cast(1 as decimal(10, 0)) ELSE cast(2 as short) END FROM t;
SELECT CASE WHEN true THEN cast(1 as decimal(10, 0)) ELSE cast(2 as int) END FROM t;
SELECT CASE WHEN true THEN cast(1 as decimal(10, 0)) ELSE cast(2 as bigint) END FROM t;
SELECT CASE WHEN true THEN cast(1 as decimal(10, 0)) ELSE cast(2 as float) END FROM t;
Expand All @@ -131,7 +110,6 @@ SELECT CASE WHEN true THEN cast(1 as decimal(10, 0)) ELSE cast('2017-12-11 09:30

SELECT CASE WHEN true THEN cast(1 as string) ELSE cast(2 as tinyint) END FROM t;
SELECT CASE WHEN true THEN cast(1 as string) ELSE cast(2 as smallint) END FROM t;
SELECT CASE WHEN true THEN cast(1 as string) ELSE cast(2 as short) END FROM t;
SELECT CASE WHEN true THEN cast(1 as string) ELSE cast(2 as int) END FROM t;
SELECT CASE WHEN true THEN cast(1 as string) ELSE cast(2 as bigint) END FROM t;
SELECT CASE WHEN true THEN cast(1 as string) ELSE cast(2 as float) END FROM t;
Expand All @@ -145,7 +123,6 @@ SELECT CASE WHEN true THEN cast(1 as string) ELSE cast('2017-12-11 09:30:00' as

SELECT CASE WHEN true THEN cast('1' as binary) ELSE cast(2 as tinyint) END FROM t;
SELECT CASE WHEN true THEN cast('1' as binary) ELSE cast(2 as smallint) END FROM t;
SELECT CASE WHEN true THEN cast('1' as binary) ELSE cast(2 as short) END FROM t;
SELECT CASE WHEN true THEN cast('1' as binary) ELSE cast(2 as int) END FROM t;
SELECT CASE WHEN true THEN cast('1' as binary) ELSE cast(2 as bigint) END FROM t;
SELECT CASE WHEN true THEN cast('1' as binary) ELSE cast(2 as float) END FROM t;
Expand All @@ -159,7 +136,6 @@ SELECT CASE WHEN true THEN cast('1' as binary) ELSE cast('2017-12-11 09:30:00' a

SELECT CASE WHEN true THEN cast(1 as boolean) ELSE cast(2 as tinyint) END FROM t;
SELECT CASE WHEN true THEN cast(1 as boolean) ELSE cast(2 as smallint) END FROM t;
SELECT CASE WHEN true THEN cast(1 as boolean) ELSE cast(2 as short) END FROM t;
SELECT CASE WHEN true THEN cast(1 as boolean) ELSE cast(2 as int) END FROM t;
SELECT CASE WHEN true THEN cast(1 as boolean) ELSE cast(2 as bigint) END FROM t;
SELECT CASE WHEN true THEN cast(1 as boolean) ELSE cast(2 as float) END FROM t;
Expand All @@ -173,7 +149,6 @@ SELECT CASE WHEN true THEN cast(1 as boolean) ELSE cast('2017-12-11 09:30:00' as

SELECT CASE WHEN true THEN cast('2017-12-12 09:30:00.0' as timestamp) ELSE cast(2 as tinyint) END FROM t;
SELECT CASE WHEN true THEN cast('2017-12-12 09:30:00.0' as timestamp) ELSE cast(2 as smallint) END FROM t;
SELECT CASE WHEN true THEN cast('2017-12-12 09:30:00.0' as timestamp) ELSE cast(2 as short) END FROM t;
SELECT CASE WHEN true THEN cast('2017-12-12 09:30:00.0' as timestamp) ELSE cast(2 as int) END FROM t;
SELECT CASE WHEN true THEN cast('2017-12-12 09:30:00.0' as timestamp) ELSE cast(2 as bigint) END FROM t;
SELECT CASE WHEN true THEN cast('2017-12-12 09:30:00.0' as timestamp) ELSE cast(2 as float) END FROM t;
Expand All @@ -187,7 +162,6 @@ SELECT CASE WHEN true THEN cast('2017-12-12 09:30:00.0' as timestamp) ELSE cast(

SELECT CASE WHEN true THEN cast('2017-12-12 09:30:00' as date) ELSE cast(2 as tinyint) END FROM t;
SELECT CASE WHEN true THEN cast('2017-12-12 09:30:00' as date) ELSE cast(2 as smallint) END FROM t;
SELECT CASE WHEN true THEN cast('2017-12-12 09:30:00' as date) ELSE cast(2 as short) END FROM t;
SELECT CASE WHEN true THEN cast('2017-12-12 09:30:00' as date) ELSE cast(2 as int) END FROM t;
SELECT CASE WHEN true THEN cast('2017-12-12 09:30:00' as date) ELSE cast(2 as bigint) END FROM t;
SELECT CASE WHEN true THEN cast('2017-12-12 09:30:00' as date) ELSE cast(2 as float) END FROM t;
Expand Down
26 changes: 0 additions & 26 deletions sql/core/src/test/resources/sql-tests/inputs/typeCoercion/native/ifCoercion.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ CREATE TEMPORARY VIEW t AS SELECT 1;

SELECT IF(true, cast(1 as tinyint), cast(2 as tinyint)) FROM t;
SELECT IF(true, cast(1 as tinyint), cast(2 as smallint)) FROM t;
SELECT IF(true, cast(1 as tinyint), cast(2 as short)) FROM t;
SELECT IF(true, cast(1 as tinyint), cast(2 as int)) FROM t;
SELECT IF(true, cast(1 as tinyint), cast(2 as bigint)) FROM t;
SELECT IF(true, cast(1 as tinyint), cast(2 as float)) FROM t;
Expand All @@ -33,7 +32,6 @@ SELECT IF(true, cast(1 as tinyint), cast('2017-12-11 09:30:00' as date)) FROM t;

SELECT IF(true, cast(1 as smallint), cast(2 as tinyint)) FROM t;
SELECT IF(true, cast(1 as smallint), cast(2 as smallint)) FROM t;
SELECT IF(true, cast(1 as smallint), cast(2 as short)) FROM t;
SELECT IF(true, cast(1 as smallint), cast(2 as int)) FROM t;
SELECT IF(true, cast(1 as smallint), cast(2 as bigint)) FROM t;
SELECT IF(true, cast(1 as smallint), cast(2 as float)) FROM t;
Expand All @@ -45,23 +43,8 @@ SELECT IF(true, cast(1 as smallint), cast(2 as boolean)) FROM t;
SELECT IF(true, cast(1 as smallint), cast('2017-12-11 09:30:00.0' as timestamp)) FROM t;
SELECT IF(true, cast(1 as smallint), cast('2017-12-11 09:30:00' as date)) FROM t;

SELECT IF(true, cast(1 as short), cast(2 as tinyint)) FROM t;
SELECT IF(true, cast(1 as short), cast(2 as smallint)) FROM t;
SELECT IF(true, cast(1 as short), cast(2 as short)) FROM t;
SELECT IF(true, cast(1 as short), cast(2 as int)) FROM t;
SELECT IF(true, cast(1 as short), cast(2 as bigint)) FROM t;
SELECT IF(true, cast(1 as short), cast(2 as float)) FROM t;
SELECT IF(true, cast(1 as short), cast(2 as double)) FROM t;
SELECT IF(true, cast(1 as short), cast(2 as decimal(10, 0))) FROM t;
SELECT IF(true, cast(1 as short), cast(2 as string)) FROM t;
SELECT IF(true, cast(1 as short), cast('2' as binary)) FROM t;
SELECT IF(true, cast(1 as short), cast(2 as boolean)) FROM t;
SELECT IF(true, cast(1 as short), cast('2017-12-11 09:30:00.0' as timestamp)) FROM t;
SELECT IF(true, cast(1 as short), cast('2017-12-11 09:30:00' as date)) FROM t;

SELECT IF(true, cast(1 as int), cast(2 as tinyint)) FROM t;
SELECT IF(true, cast(1 as int), cast(2 as smallint)) FROM t;
SELECT IF(true, cast(1 as int), cast(2 as short)) FROM t;
SELECT IF(true, cast(1 as int), cast(2 as int)) FROM t;
SELECT IF(true, cast(1 as int), cast(2 as bigint)) FROM t;
SELECT IF(true, cast(1 as int), cast(2 as float)) FROM t;
Expand All @@ -75,7 +58,6 @@ SELECT IF(true, cast(1 as int), cast('2017-12-11 09:30:00' as date)) FROM t;

SELECT IF(true, cast(1 as bigint), cast(2 as tinyint)) FROM t;
SELECT IF(true, cast(1 as bigint), cast(2 as smallint)) FROM t;
SELECT IF(true, cast(1 as bigint), cast(2 as short)) FROM t;
SELECT IF(true, cast(1 as bigint), cast(2 as int)) FROM t;
SELECT IF(true, cast(1 as bigint), cast(2 as bigint)) FROM t;
SELECT IF(true, cast(1 as bigint), cast(2 as float)) FROM t;
Expand All @@ -89,7 +71,6 @@ SELECT IF(true, cast(1 as bigint), cast('2017-12-11 09:30:00' as date)) FROM t;

SELECT IF(true, cast(1 as float), cast(2 as tinyint)) FROM t;
SELECT IF(true, cast(1 as float), cast(2 as smallint)) FROM t;
SELECT IF(true, cast(1 as float), cast(2 as short)) FROM t;
SELECT IF(true, cast(1 as float), cast(2 as int)) FROM t;
SELECT IF(true, cast(1 as float), cast(2 as bigint)) FROM t;
SELECT IF(true, cast(1 as float), cast(2 as float)) FROM t;
Expand All @@ -103,7 +84,6 @@ SELECT IF(true, cast(1 as float), cast('2017-12-11 09:30:00' as date)) FROM t;

SELECT IF(true, cast(1 as double), cast(2 as tinyint)) FROM t;
SELECT IF(true, cast(1 as double), cast(2 as smallint)) FROM t;
SELECT IF(true, cast(1 as double), cast(2 as short)) FROM t;
SELECT IF(true, cast(1 as double), cast(2 as int)) FROM t;
SELECT IF(true, cast(1 as double), cast(2 as bigint)) FROM t;
SELECT IF(true, cast(1 as double), cast(2 as float)) FROM t;
Expand All @@ -117,7 +97,6 @@ SELECT IF(true, cast(1 as double), cast('2017-12-11 09:30:00' as date)) FROM t;

SELECT IF(true, cast(1 as decimal(10, 0)), cast(2 as tinyint)) FROM t;
SELECT IF(true, cast(1 as decimal(10, 0)), cast(2 as smallint)) FROM t;
SELECT IF(true, cast(1 as decimal(10, 0)), cast(2 as short)) FROM t;
SELECT IF(true, cast(1 as decimal(10, 0)), cast(2 as int)) FROM t;
SELECT IF(true, cast(1 as decimal(10, 0)), cast(2 as bigint)) FROM t;
SELECT IF(true, cast(1 as decimal(10, 0)), cast(2 as float)) FROM t;
Expand All @@ -131,7 +110,6 @@ SELECT IF(true, cast(1 as decimal(10, 0)), cast('2017-12-11 09:30:00' as date))

SELECT IF(true, cast(1 as string), cast(2 as tinyint)) FROM t;
SELECT IF(true, cast(1 as string), cast(2 as smallint)) FROM t;
SELECT IF(true, cast(1 as string), cast(2 as short)) FROM t;
SELECT IF(true, cast(1 as string), cast(2 as int)) FROM t;
SELECT IF(true, cast(1 as string), cast(2 as bigint)) FROM t;
SELECT IF(true, cast(1 as string), cast(2 as float)) FROM t;
Expand All @@ -145,7 +123,6 @@ SELECT IF(true, cast(1 as string), cast('2017-12-11 09:30:00' as date)) FROM t;

SELECT IF(true, cast('1' as binary), cast(2 as tinyint)) FROM t;
SELECT IF(true, cast('1' as binary), cast(2 as smallint)) FROM t;
SELECT IF(true, cast('1' as binary), cast(2 as short)) FROM t;
SELECT IF(true, cast('1' as binary), cast(2 as int)) FROM t;
SELECT IF(true, cast('1' as binary), cast(2 as bigint)) FROM t;
SELECT IF(true, cast('1' as binary), cast(2 as float)) FROM t;
Expand All @@ -159,7 +136,6 @@ SELECT IF(true, cast('1' as binary), cast('2017-12-11 09:30:00' as date)) FROM t

SELECT IF(true, cast(1 as boolean), cast(2 as tinyint)) FROM t;
SELECT IF(true, cast(1 as boolean), cast(2 as smallint)) FROM t;
SELECT IF(true, cast(1 as boolean), cast(2 as short)) FROM t;
SELECT IF(true, cast(1 as boolean), cast(2 as int)) FROM t;
SELECT IF(true, cast(1 as boolean), cast(2 as bigint)) FROM t;
SELECT IF(true, cast(1 as boolean), cast(2 as float)) FROM t;
Expand All @@ -173,7 +149,6 @@ SELECT IF(true, cast(1 as boolean), cast('2017-12-11 09:30:00' as date)) FROM t;

SELECT IF(true, cast('2017-12-12 09:30:00.0' as timestamp), cast(2 as tinyint)) FROM t;
SELECT IF(true, cast('2017-12-12 09:30:00.0' as timestamp), cast(2 as smallint)) FROM t;
SELECT IF(true, cast('2017-12-12 09:30:00.0' as timestamp), cast(2 as short)) FROM t;
SELECT IF(true, cast('2017-12-12 09:30:00.0' as timestamp), cast(2 as int)) FROM t;
SELECT IF(true, cast('2017-12-12 09:30:00.0' as timestamp), cast(2 as bigint)) FROM t;
SELECT IF(true, cast('2017-12-12 09:30:00.0' as timestamp), cast(2 as float)) FROM t;
Expand All @@ -187,7 +162,6 @@ SELECT IF(true, cast('2017-12-12 09:30:00.0' as timestamp), cast('2017-12-11 09:

SELECT IF(true, cast('2017-12-12 09:30:00' as date), cast(2 as tinyint)) FROM t;
SELECT IF(true, cast('2017-12-12 09:30:00' as date), cast(2 as smallint)) FROM t;
SELECT IF(true, cast('2017-12-12 09:30:00' as date), cast(2 as short)) FROM t;
SELECT IF(true, cast('2017-12-12 09:30:00' as date), cast(2 as int)) FROM t;
SELECT IF(true, cast('2017-12-12 09:30:00' as date), cast(2 as bigint)) FROM t;
SELECT IF(true, cast('2017-12-12 09:30:00' as date), cast(2 as float)) FROM t;
Expand Down
Loading