Skip to content

[SPARK-22757][Kubernetes] Enable use of remote dependencies (http, s3, gcs, etc.) in Kubernetes mode #19954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
liyinan926 wants to merge 14 commits into from
Closed

[SPARK-22757][Kubernetes] Enable use of remote dependencies (http, s3, gcs, etc.) in Kubernetes mode #19954

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d3cbbdd
[SPARK-22757][Kubernetes] Enable use of remote dependencies in Kubern…
liyinan926 Dec 12, 2017
5d2cbc8
Addressed first round of comments
liyinan926 Dec 15, 2017
4ee76af
Addressed the second round of comments
liyinan926 Dec 16, 2017
9c8051a
Create one task per jar/file to download in the init-container
liyinan926 Dec 16, 2017
1f65417
More review comments
liyinan926 Dec 18, 2017
109ad80
Shorten variable names
liyinan926 Dec 19, 2017
c21fdcf
Removed traits that have only a single implementation
liyinan926 Dec 19, 2017
a3cd71d
Remove unused class arguments
liyinan926 Dec 19, 2017
23c5cd9
Improved documentation
liyinan926 Dec 19, 2017
2ec15c4
Addressed latest round of comments
liyinan926 Dec 20, 2017
5d1f889
Addressed more comments
liyinan926 Dec 21, 2017
9d9c841
Updated names of two configuration properties
liyinan926 Dec 22, 2017
c51bc56
Addressed more comments
liyinan926 Dec 25, 2017
28343fb
Addressed one more comment
liyinan926 Dec 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updated names of two configuration properties
  • Loading branch information
@liyinan926
liyinan926 committed Dec 23, 2017
commit 9d9c841b3528e0806280a58a0a8acaa456aa6e44
13 changes: 6 additions & 7 deletions resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,17 +152,16 @@ private[spark] object Config extends Logging {
.createOptional

val INIT_CONTAINER_MOUNT_TIMEOUT =
ConfigBuilder("spark.kubernetes.mountDependencies.mountTimeout")
.doc("Timeout before aborting the attempt to download and unpack local dependencies from " +
"remote locations and the resource staging server when initializing the driver and " +
"executor pods.")
ConfigBuilder("spark.kubernetes.mountDependencies.timeout")
Copy link
Contributor

@jiangxb1987 jiangxb1987 Dec 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: spark.kubernetes.initContainer.mountDependencies.timeout?

Copy link
Contributor Author

@liyinan926 liyinan926 Dec 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the response regarding spark.kubernetes.mountDependencies.maxSimultaneousDownloads.

.doc("Timeout before aborting the attempt to download and unpack dependencies from remote " +
"locations into the driver and executor pods.")
.timeConf(TimeUnit.MINUTES)
Copy link
Contributor

@jiangxb1987 jiangxb1987 Dec 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not TimeUnit.SECONDS?

Copy link
Contributor Author

@liyinan926 liyinan926 Dec 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

.createWithDefault(5)

val INIT_CONTAINER_MAX_THREAD_POOL_SIZE =
ConfigBuilder("spark.kubernetes.initContainer.maxThreadPoolSize")
.doc("Maximum size of the thread pool in the init-container for downloading remote " +
"dependencies.")
ConfigBuilder("spark.kubernetes.mountDependencies.maxSimultaneousDownloads")
Copy link
Contributor

@jiangxb1987 jiangxb1987 Dec 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: spark.kubernetes.initContainer.mountDependencies.maxSimultaneousDownloads?

Copy link
Contributor Author

@liyinan926 liyinan926 Dec 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the current name is already pretty long. Adding initContainer makes it even longer without much added value.

.doc("Maximum number of remote dependencies to download simultaneously in a driver or " +
"executor pod.")
.intConf
.createWithDefault(5)

Expand Down