Skip to content

[SPARK-22766] Install R linter package in spark lib directory #19959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
falaki wants to merge 3 commits into from
Closed

[SPARK-22766] Install R linter package in spark lib directory #19959

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2376b0b
Installing lintr package in Spark library location instead of site-li…
falaki Dec 12, 2017
6892725
Installing lintr from github no mwatter what
falaki Dec 12, 2017
4355fae
Updating Rcpp to 0.12.13 and using a CRAN a snapshot
falaki Dec 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions dev/lint-r.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,17 @@ if (! library(SparkR, lib.loc = LOCAL_LIB_LOC, logical.return = TRUE)) {
stop("You should install SparkR in a local directory with `R/install-dev.sh`.")
}

# Installs lintr from Github in a local directory.
# Installs lintr and dependencies from Github in a local directory.

# Pinning Rcpp version to CRAN snapshot from 2017-10-15
install.packages("Rcpp", repos = "https://cran.microsoft.com/snapshot/2017-10-15", lib = LOCAL_LIB_LOC)

# NOTE: The CRAN's version is too old to adapt to our rules.
if ("lintr" %in% row.names(installed.packages()) == FALSE) {
devtools::install_github("jimhester/lintr@5431140")
}
# NOTE: We won't use the lintr package that might have been installed on the test machine
devtools::with_libpaths(new = LOCAL_LIB_LOC, devtools::install_github("jimhester/lintr@5431140"))

library(lintr)
library(lintr, lib.loc = LOCAL_LIB_LOC)
library(xmlparsedata, lib.loc = LOCAL_LIB_LOC)
library(methods)
library(testthat)
path.to.package <- file.path(SPARK_ROOT_DIR, "R", "pkg")
Expand Down