[SPARK-22496][SQL] thrift server adds operation logs #19961
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## What changes were proposed in this pull request? since hive 2.0+ upgrades log4j to log4j2，a lot of [changes](https://issues.apache.org/jira/browse/HIVE-11304) are made working on it. as spark is not to ready to update its inner hive version(1.2.1) , so I manage to make little changes. the function registerCurrentOperationLog is moved from SQLOperstion to its parent class ExecuteStatementOperation so spark can use it. ## How was this patch tested? manual test Author: zouchenjun <[email protected]> Closes apache#19721 from ChenjunZou/operation-log.
Member
|
ok to test |
HyukjinKwon
reviewed
Dec 13, 2017
| if (isOperationLogEnabled) { | ||
| if (operationLog == null) { | ||
| LOG.warn("Failed to get current OperationLog object of Operation: " + | ||
| getHandle().getHandleIdentifier()); |
Member
There was a problem hiding this comment.
I think the indentation should be double spaced.
Member
There was a problem hiding this comment.
This was resolved by me when I did the merge.
|
Test build #84825 has finished for PR 19961 at commit
|
Member
|
ok to test |
|
Test build #84933 has finished for PR 19961 at commit
|
Member
|
LGTM Thanks! Merged to master. |
Member
|
Now, SparkR started failing, after we remerge this PR. It sounds like it is related to the merge of this PR. I have to revert it. Sorry for that. |
Member
|
It indeed looked somehow related as the CRAN was broken at the similar time. BTW, seems unrelated at the end. Let me bring it back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
since hive 2.0+ upgrades log4j to log4j2，a lot of changes are made working on it.
as spark is not to ready to update its inner hive version(1.2.1) , so I manage to make little changes.
the function registerCurrentOperationLog is moved from SQLOperstion to its parent class ExecuteStatementOperation so spark can use it.
How was this patch tested?
manual test
Closes #19721 from ChenjunZou/operation-log.