[SPARK-3087][MLLIB] fix col indexing bug in chi-square and add a check for number of distinct values #1997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
There was a problem hiding this comment.
Should use zipWithIndex before slicing.
|
QA tests have started for PR 1997 at commit
|
mengxr
changed the title
mengxr
changed the title
|
QA tests have finished for PR 1997 at commit
|
Member
|
@mengxr LGTM! I didn't find any bugs or style issues. |
Contributor
Author
|
Thanks! I've merged this into master and branch-1.1. |
asfgit
pushed a commit
that referenced
this pull request
Aug 18, 2014
…k for number of distinct values There is a bug determining the column index. dorx Author: Xiangrui Meng <[email protected]> Closes #1997 from mengxr/chisq-index and squashes the following commits: 8fc2ab2 [Xiangrui Meng] fix col indexing bug and add a check for number of distinct values (cherry picked from commit c77f406) Signed-off-by: Xiangrui Meng <[email protected]>
xiliu82
pushed a commit
to xiliu82/spark
that referenced
this pull request
Sep 4, 2014
…k for number of distinct values There is a bug determining the column index. dorx Author: Xiangrui Meng <[email protected]> Closes apache#1997 from mengxr/chisq-index and squashes the following commits: 8fc2ab2 [Xiangrui Meng] fix col indexing bug and add a check for number of distinct values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug determining the column index. @dorx