Skip to content

[SPARK-22822][TEST] Basic tests for WindowFrameCoercion and DecimalPrecision #20008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wangyum wants to merge 8 commits into from
Closed

[SPARK-22822][TEST] Basic tests for WindowFrameCoercion and DecimalPrecision #20008

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
05acae3
Basic tests for FunctionArgumentConversion and DecimalPrecision
wangyum Dec 18, 2017
3ff5c9b
simplify
wangyum Dec 19, 2017
16f0a99
Fix binary error
wangyum Dec 20, 2017
b4c5339
remove functionArgumentConversion.sql and add windowFrameCoercion.sql
wangyum Dec 20, 2017
19bcca1
TypeCollection should use simpleString
wangyum Dec 20, 2017
3291339
Add a single quote
wangyum Dec 20, 2017
a49d1cc
Fix test error
wangyum Dec 20, 2017
ec07bc2
Fix test error
wangyum Dec 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
TypeCollection should use simpleString
  • Loading branch information
@wangyum
wangyum committed Dec 20, 2017
commit 19bcca13ab03c9a5cb5399476e1afac26a30ec49
2 changes: 1 addition & 1 deletion ...catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ case class SpecifiedWindowFrame(
case e: Expression if !frameType.inputType.acceptsType(e.dataType) =>
TypeCheckFailure(
s"The data type of the $location bound '${e.dataType} does not match " +
s"the expected data type '${frameType.inputType}'.")
s"the expected data type '${frameType.inputType.simpleString}'.")
Copy link
Member Author

@wangyum wangyum Dec 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise the result is:

cannot resolve 'RANGE BETWEEN CURRENT ROW AND CAST(1 AS STRING) FOLLOWING' due to data type mismatch: The data type of the upper bound 'StringType does not match the expected data type 'org.apache.spark.sql.types.TypeCollection@7ff36201'.; line 1 pos 21

case _ => TypeCheckSuccess
}

Expand Down
4 changes: 2 additions & 2 deletions ...core/src/test/resources/sql-tests/results/typeCoercion/native/windowFrameCoercion.sql.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ SELECT COUNT(*) OVER (PARTITION BY 1 ORDER BY cast(1 as string) DESC RANGE BETWE
struct<>
-- !query 20 output
org.apache.spark.sql.AnalysisException
cannot resolve 'RANGE BETWEEN CURRENT ROW AND CAST(1 AS STRING) FOLLOWING' due to data type mismatch: The data type of the upper bound 'StringType does not match the expected data type 'org.apache.spark.sql.types.TypeCollection@7ff36201'.; line 1 pos 21
cannot resolve 'RANGE BETWEEN CURRENT ROW AND CAST(1 AS STRING) FOLLOWING' due to data type mismatch: The data type of the upper bound 'StringType does not match the expected data type '(numeric or calendarinterval)'.; line 1 pos 21


-- !query 21
Expand All @@ -186,7 +186,7 @@ SELECT COUNT(*) OVER (PARTITION BY 1 ORDER BY cast(1 as boolean) DESC RANGE BETW
struct<>
-- !query 22 output
org.apache.spark.sql.AnalysisException
cannot resolve 'RANGE BETWEEN CURRENT ROW AND CAST(1 AS BOOLEAN) FOLLOWING' due to data type mismatch: The data type of the upper bound 'BooleanType does not match the expected data type 'org.apache.spark.sql.types.TypeCollection@7ff36201'.; line 1 pos 21
cannot resolve 'RANGE BETWEEN CURRENT ROW AND CAST(1 AS BOOLEAN) FOLLOWING' due to data type mismatch: The data type of the upper bound 'BooleanType does not match the expected data type '(numeric or calendarinterval)'.; line 1 pos 21


-- !query 23
Expand Down