Skip to content

[SPARK-22832][ML] BisectingKMeans unpersist unused datasets #20017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhengruifeng wants to merge 3 commits into from
Closed

[SPARK-22832][ML] BisectingKMeans unpersist unused datasets #20017

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e0d266
create pr
zhengruifeng Dec 19, 2017
e05cc26
lint
zhengruifeng Dec 19, 2017
3767e80
update style
zhengruifeng Dec 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
  • Loading branch information
@zhengruifeng
zhengruifeng committed Dec 19, 2017
commit e05cc267d9246e6ba662bfb882bfb5864600fb2b
2 changes: 1 addition & 1 deletion mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeans.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ class BisectingKMeans private (
level += 1
}
if (preIndices != null) preIndices.unpersist(blocking = false)
Copy link
Member

@srowen srowen Dec 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we usually write "blocking ="? there's only one argument.
I'd use braces and put the body on the next line too.

if(indices != null) indices.unpersist(blocking = false)
if (indices != null) indices.unpersist(blocking = false)
norms.unpersist(blocking = false)
val clusters = activeClusters ++ inactiveClusters
val root = buildTree(clusters)
Expand Down