Skip to content

[SPARK-22036][SQL] Decimal multiplication with high precision/scale often returns NULL #20023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mgaido91 wants to merge 17 commits into from
Closed

[SPARK-22036][SQL] Decimal multiplication with high precision/scale often returns NULL #20023

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
3037d4a
[SPARK-22036][SQL] Decimal multiplication with high precision/scale o…
mgaido91 Dec 17, 2017
6701a54
introduce spark.sql.decimalOperations.allowTruncat
mgaido91 Jan 9, 2018
20616fd
Merge branch 'master' of github.com:apache/spark into SPARK-22036
mgaido91 Jan 9, 2018
ecd6a2a
fix UT
mgaido91 Jan 10, 2018
cb62433
rename to allowPrecisionLoss
mgaido91 Jan 15, 2018
77e445f
address comments
mgaido91 Jan 15, 2018
519571d
fix typo
mgaido91 Jan 15, 2018
1f36cf6
fix build error
mgaido91 Jan 15, 2018
1ff819d
address comments
mgaido91 Jan 16, 2018
c1c5781
allowPrecisionLoss true by default
mgaido91 Jan 16, 2018
3e79a07
readability fix
mgaido91 Jan 16, 2018
090659f
adding example in comments for literals
mgaido91 Jan 16, 2018
cf3b372
update migration section
mgaido91 Jan 16, 2018
03644fe
address comments
mgaido91 Jan 17, 2018
7653e6d
move tests in decimalArithmeticOperations.sql
mgaido91 Jan 17, 2018
2b66098
rename to fromLiteral
mgaido91 Jan 17, 2018
b4b0350
docs fix
mgaido91 Jan 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix build error
  • Loading branch information
@mgaido91
mgaido91 committed Jan 15, 2018
commit 1f36cf6bcf784a04d77b2b5153cd504e6155c875
4 changes: 2 additions & 2 deletions sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1518,7 +1518,7 @@ class SQLQuerySuite extends QueryTest with SharedSQLContext {
}

test("decimal precision with multiply/division") {
Copy link
Contributor

@cloud-fan cloud-fan Jan 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just move these tests to the new decimal.sql?

withSQLConf(SQLConf.DECIMAL_OPERATIONS_ALLOW_TRUNCAT.key -> "false") {
withSQLConf(SQLConf.DECIMAL_OPERATIONS_ALLOW_PREC_LOSS.key -> "false") {
checkAnswer(sql("select 10.3 * 3.0"), Row(BigDecimal("30.90")))
checkAnswer(sql("select 10.3000 * 3.0"), Row(BigDecimal("30.90000")))
checkAnswer(sql("select 10.30000 * 30.0"), Row(BigDecimal("309.000000")))
Expand All @@ -1535,7 +1535,7 @@ class SQLQuerySuite extends QueryTest with SharedSQLContext {
checkAnswer(sql("select 10.3000000000000000000 / 3.00000000000000000"),
Row(BigDecimal("3.4333333333333333333333333333", new MathContext(38))))
}
withSQLConf(SQLConf.DECIMAL_OPERATIONS_ALLOW_TRUNCAT.key -> "true") {
withSQLConf(SQLConf.DECIMAL_OPERATIONS_ALLOW_PREC_LOSS.key -> "true") {
checkAnswer(sql("select 10.3 * 3.0"), Row(BigDecimal("30.90")))
checkAnswer(sql("select 10.3000 * 3.0"), Row(BigDecimal("30.90000")))
checkAnswer(sql("select 10.30000 * 30.0"), Row(BigDecimal("309.000000")))
Expand Down