Skip to content

SPARK-22896 Improvement in String interpolation #20070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chetkhatri wants to merge 12 commits into from
Closed

SPARK-22896 Improvement in String interpolation #20070

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9916fd1
SPARK-22896 Improvement in String interpolation
chetkhatri Dec 24, 2017
162ac27
SPARK-22896 Improvement in String interpolation - fixed typo
chetkhatri Dec 24, 2017
aa2de00
Merge branch 'master' of https://github.com/apache/spark into mllib-c…
chetkhatri Dec 24, 2017
74d41d7
graphx changed got merged to mllib example
chetkhatri Dec 26, 2017
8d729fa
All examples under spark scala - String interpolation has implemented
chetkhatri Dec 26, 2017
5507cad
All examples under spark scala - String interpolation has implemented…
chetkhatri Dec 26, 2017
79e6789
Spark scala code change for request addressed
chetkhatri Dec 28, 2017
70ce734
new line at the end of file added
chetkhatri Dec 29, 2017
0321faf
typo fixed
chetkhatri Dec 29, 2017
c33e90c
Review changes addressed
chetkhatri Dec 31, 2017
18d047f
Changes - II addressed
chetkhatri Jan 1, 2018
e891f53
Changes - III addressed
chetkhatri Jan 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Changes - III addressed
  • Loading branch information
@chetkhatri
chetkhatri committed Jan 1, 2018
commit e891f53dfd609ef9cb46f70147c59f1113c7c0cb
2 changes: 1 addition & 1 deletion examples/src/main/java/org/apache/spark/examples/ml/JavaQuantileDiscretizerExample.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public static void main(String[] args) {
.setNumBuckets(3);

Dataset<Row> result = discretizer.fit(df).transform(df);
result.show();
result.show(false);
// $example off$
spark.stop();
}
Expand Down
2 changes: 1 addition & 1 deletion examples/src/main/scala/org/apache/spark/examples/ml/QuantileDiscretizerExample.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ object QuantileDiscretizerExample {
.setNumBuckets(3)

val result = discretizer.fit(df).transform(df)
result.show()
result.show(false)
Copy link
Member

@srowen srowen Dec 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more question - is it necessary to make this not truncate?

Copy link
Contributor Author

@chetkhatri chetkhatri Dec 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're following same style in other examples so it is good to do.

Copy link
Member

@srowen srowen Dec 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which other examples? most do not set this, and the Java equivalent doesn't either. If there's a good reason that the output needs to be untruncated, that's fine, just also change the Java example.

Copy link
Contributor Author

@chetkhatri chetkhatri Jan 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srowen correct either way it works for ex. examples/ml/LDAExamples.scala

// $example off$

spark.stop()
Expand Down
4 changes: 2 additions & 2 deletions examples/src/main/scala/org/apache/spark/examples/mllib/StratifiedSamplingExample.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ object StratifiedSamplingExample {
val exactSample = data.sampleByKeyExact(withReplacement = false, fractions = fractions)
// $example off$

println(s"approxSample size is ${approxSample.collect().size.toString}")
println(s"approxSample size is ${approxSample.collect().size}")
approxSample.collect().foreach(println)

println(s"exactSample its size is ${exactSample.collect().size.toString}")
println(s"exactSample its size is ${exactSample.collect().size}")
exactSample.collect().foreach(println)

sc.stop()
Expand Down