Skip to content

Conversation

@mgaido91
Copy link
Contributor

What changes were proposed in this pull request?

Test coverage for arithmetic operations leading to:

  1. Precision loss
  2. Overflow

Moreover, tests for casting bad string to other input types and for using bad string as operators of some functions.

How was this patch tested?

added tests

@SparkQA
Copy link

SparkQA commented Dec 26, 2017

Test build #85412 has finished for PR 20084 at commit 7a9650a.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 27, 2017

Test build #85433 has finished for PR 20084 at commit 103c0e7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mgaido91
Copy link
Contributor Author

cc @gatorsmile

Copy link
Member

@gatorsmile gatorsmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gatorsmile
Copy link
Member

Thanks! Merged to master.

@asfgit asfgit closed this in 774715d Dec 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants