Skip to content

[SPARK-22324][SQL][PYTHON][FOLLOW-UP] Update setup.py file. #20089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ueshin wants to merge 5 commits into from
Closed

[SPARK-22324][SQL][PYTHON][FOLLOW-UP] Update setup.py file. #20089

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
36614af
Add pyarrow to setup.py.
ueshin Dec 27, 2017
bee3c69
Add 'Programming Language :: Python :: 3.6' to classifiers.
ueshin Dec 27, 2017
896f752
Update README.md.
ueshin Dec 27, 2017
e142e69
Add some details describing extra requirements.
ueshin Dec 27, 2017
d8d9564
Use the simple description.
ueshin Dec 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,4 @@ The Python packaging for Spark is not intended to replace all of the other use c

## Python Requirements

At its core PySpark depends on Py4J (currently version 0.10.6), but additional sub-packages have their own requirements (including numpy and pandas).
At its core PySpark depends on Py4J (currently version 0.10.6), but additional sub-packages might have their own requirements declared as "Extras" (including numpy, pandas, and pyarrow). You can install the requirements by specifying their extra names.
Copy link
Member

@HyukjinKwon HyukjinKwon Dec 27, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. How about simply like ... :

At its core PySpark depends on Py4J (currently version 0.10.6), but some additional sub-packages have their own 
extra requirements for some features (including numpy, pandas, and pyarrow).

for now? I just noticed we are a bit unclear on this (e.g., actually I have been under impression that NumPy is required for ML/MLlib so far) but I think this roughly describes it correctly and is good enough.

Will maybe try to make a PR to fully describe the dependencies and related features later. This PR targets PyArrow anyway.

Copy link
Member

@HyukjinKwon HyukjinKwon Dec 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big deal anyway. I am actually fine as is too if you prefer @ueshin.

Copy link
Member Author

@ueshin ueshin Dec 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the simple one you suggested and leave the detailed description for the future prs.

3 changes: 2 additions & 1 deletion python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ def _supports_symlinks():
extras_require={
'ml': ['numpy>=1.7'],
'mllib': ['numpy>=1.7'],
'sql': ['pandas>=0.19.2']
'sql': ['pandas>=0.19.2', 'pyarrow>=0.8.0']
Copy link
Member

@viirya viirya Dec 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If no pyarrow is installed, will setup force users to install it?

Copy link
Member

@HyukjinKwon HyukjinKwon Dec 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, extras_require does not do anything in normal cases but they can be installed together with a dev option via pip IIRC.

},
classifiers=[
'Development Status :: 5 - Production/Stable',
Expand All @@ -210,6 +210,7 @@ def _supports_symlinks():
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.4',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: Implementation :: CPython',
'Programming Language :: Python :: Implementation :: PyPy']
)
Expand Down