Skip to content

[SPARK-22938] Assert that SQLConf.get is accessed only on the driver. #20136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
juliuszsompolski wants to merge 4 commits into from
Closed

[SPARK-22938] Assert that SQLConf.get is accessed only on the driver. #20136

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d2b3bc6
[SPARK-22938] Assert that SQLConf.get is accessed only on the driver.
juliuszsompolski Dec 14, 2017
d5ecab9
remarks
juliuszsompolski Jan 2, 2018
43ecd30
try putting it in SQLConf constructor
juliuszsompolski Jan 2, 2018
1ecb766
assert msg
juliuszsompolski Jan 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
assert msg
  • Loading branch information
@juliuszsompolski
juliuszsompolski committed Jan 2, 2018
commit 1ecb766a42bafd481674df4c8c06a23977142d6e
3 changes: 2 additions & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1091,7 +1091,8 @@ class SQLConf extends Serializable with Logging {

if (Utils.isTesting && SparkEnv.get != null) {
// assert that we're only accessing it on the driver.
assert(SparkEnv.get.executorId == SparkContext.DRIVER_IDENTIFIER)
assert(SparkEnv.get.executorId == SparkContext.DRIVER_IDENTIFIER,
"SQLConf should only be created and accessed on the driver.")
}

/** Only low degree of contention is expected for conf, thus NOT using ConcurrentHashMap. */
Expand Down