Skip to content

[SPARK-22950][SQL]Handle ChildFirstURLClassLoader's parent #20145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yaooqinn wants to merge 4 commits into from
Closed

[SPARK-22950][SQL]Handle ChildFirstURLClassLoader's parent #20145

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7cb0c44
child first classpath first has no regular parent
yaooqinn Jan 4, 2018
bb27e17
doc
yaooqinn Jan 4, 2018
e1a9f2e
surround with try finally
yaooqinn Jan 4, 2018
fea2490
rm one unit test
yaooqinn Jan 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
rm one unit test
  • Loading branch information
@yaooqinn
yaooqinn committed Jan 4, 2018
commit fea2490027c611fb9be61ea33ad4de962ccf2ffa
22 changes: 0 additions & 22 deletions sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveUtilsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,22 +48,6 @@ class HiveUtilsSuite extends QueryTest with SQLTestUtils with TestHiveSingleton
}
}

test("ChildFirstURLClassLoader's parent is null") {
val conf = new SparkConf
val contextClassLoader = Thread.currentThread().getContextClassLoader
val loader = new FakeChildFirstURLClassLoader(Array(), contextClassLoader)
try {
Thread.currentThread().setContextClassLoader(loader)
intercept[IllegalArgumentException](
HiveUtils.newClientForMetadata(
conf,
SparkHadoopUtil.newConfiguration(conf),
HiveUtils.newTemporaryConfiguration(useInMemoryDerby = true)))
} finally {
Thread.currentThread().setContextClassLoader(contextClassLoader)
}
}

test("ChildFirstURLClassLoader's parent is null, get spark classloader instead") {
val conf = new SparkConf
val contextClassLoader = Thread.currentThread().getContextClassLoader
Expand All @@ -79,9 +63,3 @@ class HiveUtilsSuite extends QueryTest with SQLTestUtils with TestHiveSingleton
}
}
}

/**
* A Fake [[ChildFirstURLClassLoader]] used for test
*/
private[spark] class FakeChildFirstURLClassLoader(urls: Array[URL], parent: ClassLoader)
extends MutableURLClassLoader(urls, null)