Skip to content

[SPARK-22972] Couldn't find corresponding Hive SerDe for data source provider org.apache.spark.sql.hive.orc #20165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xubo245 wants to merge 6 commits into from
Closed

[SPARK-22972] Couldn't find corresponding Hive SerDe for data source provider org.apache.spark.sql.hive.orc #20165

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fa902d6
[SPARK-22972] Couldn't find corresponding Hive SerDe for data source …
xubo245 Jan 5, 2018
cf7cbce
keep the original one and update code style
xubo245 Jan 5, 2018
b64ce53
fix scala style: Whitespace at end of line
xubo245 Jan 5, 2018
1cfa72f
add withTable and tableSchema
xubo245 Jan 8, 2018
cc4dd13
add a line
xubo245 Jan 8, 2018
3eafdfb
update style
xubo245 Jan 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sql/core/src/main/scala/org/apache/spark/sql/internal/HiveSerDe.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ object HiveSerDe {
val key = source.toLowerCase(Locale.ROOT) match {
case s if s.startsWith("org.apache.spark.sql.parquet") => "parquet"
case s if s.startsWith("org.apache.spark.sql.orc") => "orc"
Copy link
Member

@gatorsmile gatorsmile Jan 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to keep the original one. We do not want to introduce behavior breaks.

Copy link
Contributor Author

@xubo245 xubo245 Jan 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

case s if s.startsWith("org.apache.spark.sql.hive.orc") => "orc"
case s if s.equals("orcfile") => "orc"
case s if s.equals("parquetfile") => "parquet"
case s if s.equals("avrofile") => "avro"
Expand Down
17 changes: 17 additions & 0 deletions sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcSourceSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import java.io.File
import org.apache.spark.sql.Row
import org.apache.spark.sql.execution.datasources.orc.OrcSuite
import org.apache.spark.sql.hive.test.TestHiveSingleton
import org.apache.spark.sql.internal.HiveSerDe
import org.apache.spark.util.Utils

class HiveOrcSourceSuite extends OrcSuite with TestHiveSingleton {
Expand Down Expand Up @@ -62,6 +63,22 @@ class HiveOrcSourceSuite extends OrcSuite with TestHiveSingleton {
""".stripMargin)
}

test("SPARK-22972: hive orc source") {
spark.sql(
Copy link
Member

@gatorsmile gatorsmile Jan 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WithTable("normal_orc_as_source_hive")

Copy link
Contributor Author

@xubo245 xubo245 Jan 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

s"""CREATE TABLE normal_orc_as_source_hive
Copy link
Member

@gatorsmile gatorsmile Jan 5, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put it to next line. You can refer the other test cases of CREATE TABLE

Copy link
Contributor Author

@xubo245 xubo245 Jan 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

|USING org.apache.spark.sql.hive.orc
|OPTIONS (
| PATH '${new File(orcTableAsDir.getAbsolutePath).toURI}'
|)
""".stripMargin)
Copy link
Member

@gatorsmile gatorsmile Jan 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

s"""
  |CREATE TABLE $tableName
  |USING org.apache.spark.sql.hive.orc
  |OPTIONS (
  |  PATH '${new File(orcTableAsDir.getAbsolutePath).toURI}'
  |)
""".stripMargin)

Copy link
Member

@gatorsmile gatorsmile Jan 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be careful about the indents.

Copy link
Contributor Author

@xubo245 xubo245 Jan 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

spark.sql("desc formatted normal_orc_as_source_hive").show()
Copy link
Member

@gatorsmile gatorsmile Jan 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace it by

    val tableMetadata = spark.sessionState.catalog.getTableMetadata(
      TableIdentifier("normal_orc_as_source_hive"))
    assert(tableMetadata.storage.inputFormat ==
      Option("org.apache.hadoop.hive.ql.io.orc.OrcInputFormat"))
    assert(tableMetadata.storage.outputFormat ==
      Option("org.apache.hadoop.hive.ql.io.orc.OrcOutputFormat"))
    assert(tableMetadata.storage.serde ==
      Option("org.apache.hadoop.hive.ql.io.orc.OrcSerde"))

Copy link
Contributor Author

@xubo245 xubo245 Jan 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

checkAnswer(sql("SELECT COUNT(*) FROM normal_orc_as_source_hive"), Row(10))
assert(HiveSerDe.sourceToSerDe("org.apache.spark.sql.hive.orc")
.equals(HiveSerDe.sourceToSerDe("orc")))
Copy link
Member

@gatorsmile gatorsmile Jan 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add the checks:

assert(HiveSerDe.sourceToSerDe("org.apache.spark.sql.orc")
  .equals(HiveSerDe.sourceToSerDe("orc")))

Copy link
Contributor Author

@xubo245 xubo245 Jan 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

assert(HiveSerDe.sourceToSerDe("org.apache.spark.sql.orc")
.equals(HiveSerDe.sourceToSerDe("orc")))
}

test("SPARK-19459/SPARK-18220: read char/varchar column written by Hive") {
val location = Utils.createTempDir()
val uri = location.toURI
Expand Down