-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-23007][SQL][TEST] Add read schema suite for file-based data sources #20208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
181 changes: 181 additions & 0 deletions
181
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/ReadSchemaSuite.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,181 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.sql.execution.datasources | ||
|
|
||
| import org.apache.spark.sql.internal.SQLConf | ||
|
|
||
| /** | ||
| * Read schema suites have the following hierarchy and aims to guarantee users | ||
| * a backward-compatible read-schema change coverage on file-based data sources, and | ||
| * to prevent future regressions. | ||
| * | ||
| * ReadSchemaSuite | ||
| * -> CSVReadSchemaSuite | ||
| * -> HeaderCSVReadSchemaSuite | ||
| * | ||
| * -> JsonReadSchemaSuite | ||
| * | ||
| * -> OrcReadSchemaSuite | ||
| * -> VectorizedOrcReadSchemaSuite | ||
| * | ||
| * -> ParquetReadSchemaSuite | ||
| * -> VectorizedParquetReadSchemaSuite | ||
| * -> MergedParquetReadSchemaSuite | ||
| */ | ||
|
|
||
| /** | ||
| * All file-based data sources supports column addition and removal at the end. | ||
| */ | ||
| abstract class ReadSchemaSuite | ||
| extends AddColumnTest | ||
| with HideColumnAtTheEndTest { | ||
|
|
||
| var originalConf: Boolean = _ | ||
| } | ||
|
|
||
| class CSVReadSchemaSuite | ||
| extends ReadSchemaSuite | ||
| with IntegralTypeTest | ||
| with ToDoubleTypeTest | ||
| with ToDecimalTypeTest | ||
| with ToStringTypeTest { | ||
|
|
||
| override val format: String = "csv" | ||
| } | ||
|
|
||
| class HeaderCSVReadSchemaSuite | ||
| extends ReadSchemaSuite | ||
| with IntegralTypeTest | ||
| with ToDoubleTypeTest | ||
| with ToDecimalTypeTest | ||
| with ToStringTypeTest { | ||
|
|
||
| override val format: String = "csv" | ||
|
|
||
| override val options = Map("header" -> "true") | ||
| } | ||
|
|
||
| class JsonReadSchemaSuite | ||
| extends ReadSchemaSuite | ||
| with HideColumnInTheMiddleTest | ||
| with ChangePositionTest | ||
| with IntegralTypeTest | ||
| with ToDoubleTypeTest | ||
| with ToDecimalTypeTest | ||
| with ToStringTypeTest { | ||
|
|
||
| override val format: String = "json" | ||
| } | ||
|
|
||
| class OrcReadSchemaSuite | ||
| extends ReadSchemaSuite | ||
| with HideColumnInTheMiddleTest | ||
| with ChangePositionTest { | ||
|
|
||
| override val format: String = "orc" | ||
|
|
||
| override def beforeAll() { | ||
| super.beforeAll() | ||
| originalConf = spark.conf.get(SQLConf.ORC_VECTORIZED_READER_ENABLED) | ||
| spark.conf.set(SQLConf.ORC_VECTORIZED_READER_ENABLED.key, "false") | ||
| } | ||
|
|
||
| override def afterAll() { | ||
| spark.conf.set(SQLConf.ORC_VECTORIZED_READER_ENABLED.key, originalConf) | ||
| super.afterAll() | ||
| } | ||
| } | ||
|
|
||
| class VectorizedOrcReadSchemaSuite | ||
| extends ReadSchemaSuite | ||
| with HideColumnInTheMiddleTest | ||
| with ChangePositionTest | ||
| with BooleanTypeTest | ||
| with IntegralTypeTest | ||
| with ToDoubleTypeTest { | ||
|
|
||
| override val format: String = "orc" | ||
|
|
||
| override def beforeAll() { | ||
| super.beforeAll() | ||
| originalConf = spark.conf.get(SQLConf.ORC_VECTORIZED_READER_ENABLED) | ||
| spark.conf.set(SQLConf.ORC_VECTORIZED_READER_ENABLED.key, "true") | ||
| } | ||
|
|
||
| override def afterAll() { | ||
| spark.conf.set(SQLConf.ORC_VECTORIZED_READER_ENABLED.key, originalConf) | ||
| super.afterAll() | ||
| } | ||
| } | ||
|
|
||
| class ParquetReadSchemaSuite | ||
| extends ReadSchemaSuite | ||
| with HideColumnInTheMiddleTest | ||
| with ChangePositionTest { | ||
|
|
||
| override val format: String = "parquet" | ||
|
|
||
| override def beforeAll() { | ||
| super.beforeAll() | ||
| originalConf = spark.conf.get(SQLConf.PARQUET_VECTORIZED_READER_ENABLED) | ||
| spark.conf.set(SQLConf.PARQUET_VECTORIZED_READER_ENABLED.key, "false") | ||
| } | ||
|
|
||
| override def afterAll() { | ||
| spark.conf.set(SQLConf.PARQUET_VECTORIZED_READER_ENABLED.key, originalConf) | ||
| super.afterAll() | ||
| } | ||
| } | ||
|
|
||
| class VectorizedParquetReadSchemaSuite | ||
| extends ReadSchemaSuite | ||
| with HideColumnInTheMiddleTest | ||
| with ChangePositionTest { | ||
|
|
||
| override val format: String = "parquet" | ||
|
|
||
| override def beforeAll() { | ||
| super.beforeAll() | ||
| originalConf = spark.conf.get(SQLConf.PARQUET_VECTORIZED_READER_ENABLED) | ||
| spark.conf.set(SQLConf.PARQUET_VECTORIZED_READER_ENABLED.key, "true") | ||
| } | ||
|
|
||
| override def afterAll() { | ||
| spark.conf.set(SQLConf.PARQUET_VECTORIZED_READER_ENABLED.key, originalConf) | ||
| super.afterAll() | ||
| } | ||
| } | ||
|
|
||
| class MergedParquetReadSchemaSuite | ||
| extends ReadSchemaSuite | ||
| with HideColumnInTheMiddleTest | ||
| with ChangePositionTest { | ||
|
|
||
| override val format: String = "parquet" | ||
|
|
||
| override def beforeAll() { | ||
| super.beforeAll() | ||
| originalConf = spark.conf.get(SQLConf.PARQUET_SCHEMA_MERGING_ENABLED) | ||
| spark.conf.set(SQLConf.PARQUET_SCHEMA_MERGING_ENABLED.key, "true") | ||
| } | ||
|
|
||
| override def afterAll() { | ||
| spark.conf.set(SQLConf.PARQUET_SCHEMA_MERGING_ENABLED.key, originalConf) | ||
| super.afterAll() | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gatorsmile . Now, it becomes
ReadSchemaSuite.