Skip to content

[SPARK-23072][SQL][TEST] Add a Unicode schema test for file-based data sources #20266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 7 commits into from
Closed

[SPARK-23072][SQL][TEST] Add a Unicode schema test for file-based data sources #20266

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f9a35f1
[SPARK-23072][SQL] Add a Unicode schema test for file-based data sources
dongjoon-hyun Jan 14, 2018
60b8e43
Create FileBasedDataSourceSuite.
dongjoon-hyun Jan 15, 2018
144c596
Move to under `sql` package.
dongjoon-hyun Jan 15, 2018
5afaa28
Address comments.
dongjoon-hyun Jan 16, 2018
fb708b7
Move SPARK-22146, too.
dongjoon-hyun Jan 16, 2018
8fec65b
Remove unused imports.
dongjoon-hyun Jan 16, 2018
c67809c
Address comments.
dongjoon-hyun Jan 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[SPARK-23072][SQL] Add a Unicode schema test for file-based data sources
  • Loading branch information
@dongjoon-hyun
dongjoon-hyun committed Jan 14, 2018
commit f9a35f189c43e9962956ccb6cfae33c803e46b74
18 changes: 18 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2773,4 +2773,22 @@ class SQLQuerySuite extends QueryTest with SharedSQLContext {
}
}
}

Seq("orc", "parquet", "csv", "json").foreach { format =>
test(s"Write and read back unicode schema - $format") {
Copy link
Contributor

@cloud-fan cloud-fan Jan 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of keeping adding test cases in SQLQuerySuite, shall we create a dedicate test suite for file based data source now?

Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Jan 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. That's a best idea. I'll update like that.

withTempPath { path =>
val dir = path.getCanonicalPath

// scalastyle:off nonascii
val df = Seq("a").toDF("한글")
// scalastyle:on nonascii

df.write.format(format).option("header", "true").save(dir)
val answerDf = spark.read.format(format).option("header", "true").load(dir)

assert(df.schema === answerDf.schema)
checkAnswer(df, answerDf)
}
}
}
}