revert [SPARK-22785][SQL] remove ColumnVector.anyNullsSet #20452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Member
|
LGTM, and the name |
|
Test build #86869 has finished for PR 20452 at commit
|
Member
|
Overall LGTM. One question is, at #19980, we replace |
Member
|
LGTM. It is fine with me for |
|
Test build #86874 has finished for PR 20452 at commit
|
Contributor
Author
|
thanks, merging to master/2.3! |
asfgit
pushed a commit
that referenced
this pull request
Jan 31, 2018
## What changes were proposed in this pull request? In #19980 , we thought `anyNullsSet` can be simply implemented by `numNulls() > 0`. This is logically true, but may have performance problems. `OrcColumnVector` is an example. It doesn't have the `numNulls` property, only has a `noNulls` property. We will lose a lot of performance if we use `numNulls() > 0` to check null. This PR simply revert #19980, with a renaming to call it `hasNull`. Better name suggestions are welcome, e.g. `nullable`? ## How was this patch tested? existing test Author: Wenchen Fan <[email protected]> Closes #20452 from cloud-fan/null. (cherry picked from commit 48dd6a4) Signed-off-by: Wenchen Fan <[email protected]>
Member
|
Hi, @cloud-fan . |
Contributor
Author
|
thanks @dongjoon-hyun ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In #19980 , we thought
anyNullsSetcan be simply implemented bynumNulls() > 0. This is logically true, but may have performance problems.OrcColumnVectoris an example. It doesn't have thenumNullsproperty, only has anoNullsproperty. We will lose a lot of performance if we usenumNulls() > 0to check null.This PR simply revert #19980, with a renaming to call it
hasNull. Better name suggestions are welcome, e.g.nullable?How was this patch tested?
existing test