Skip to content

Conversation

@jkbradley
Copy link
Member

What changes were proposed in this pull request?

Added documentation about what MLlib guarantees in terms of loading ML models and Pipelines from old Spark versions. Discussed & confirmed on linked JIRA.

@jkbradley
Copy link
Member Author

Here's what it looks like:

screen shot 2018-02-12 at 4 34 38 pm

@SparkQA
Copy link

SparkQA commented Feb 13, 2018

Test build #87357 has finished for PR 20592 at commit 5366d16.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@WeichenXu123
Copy link
Contributor

LGTM.

Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment. LGTM


### Backwards compatibility for ML persistence

In general, MLlib maintains backwards compatibility for ML persistence. I.e., if you save an ML
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an ML -> a ML

Copy link
Member

@HyukjinKwon HyukjinKwon Feb 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I was in this too before. IIRC, I was confused of an RDD vs a RDD. I learnt English uses "an" vs "a" by how it sounds. I believe "an em-el" is correct :).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, what @HyukjinKwon said. Gotta love the irregularities of the language!

@jkbradley
Copy link
Member Author

Thanks for reviewing! I'll merge this with master and branch-2.3

asfgit pushed a commit that referenced this pull request Feb 13, 2018
…r ML persistence

## What changes were proposed in this pull request?

Added documentation about what MLlib guarantees in terms of loading ML models and Pipelines from old Spark versions.  Discussed & confirmed on linked JIRA.

Author: Joseph K. Bradley <[email protected]>

Closes #20592 from jkbradley/SPARK-23154-backwards-compat-doc.

(cherry picked from commit d58fe28)
Signed-off-by: Joseph K. Bradley <[email protected]>
@asfgit asfgit closed this in d58fe28 Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants