-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-23365][CORE] Do not adjust num executors when killing idle executors. #20604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
review feedback
- Loading branch information
commit e69851b9b5a1a6bc1ecc1c14a656d4c08572b9d7
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -336,7 +336,8 @@ private[spark] class ExecutorAllocationManager( | |
|
|
||
| // If the new target has not changed, avoid sending a message to the cluster manager | ||
| if (numExecutorsTarget < oldNumExecutorsTarget) { | ||
| // We lower the target number of executors but don't actively kill any yet. We do this | ||
| // We lower the target number of executors but don't actively kill any yet. Killing is | ||
| // controlled separately by an idle timeout. Its still helpful to reduce the target number | ||
| // in case an executor just happens to get lost (eg., bad hardware, or the cluster manager | ||
| // preempts it) -- in that case, there is no point in trying to immediately get a new | ||
| // executor, since we couldn't even use it yet. | ||
|
||
|
|
@@ -462,9 +463,7 @@ private[spark] class ExecutorAllocationManager( | |
| executorIdsToBeRemoved | ||
| } else { | ||
| // We don't want to change our target number of executors, because we already did that | ||
| // when the task backlog decreased. Normally there wouldn't be any tasks running on these | ||
| // executors, but maybe the scheduler *just* decided to run a task there -- in that case, | ||
| // we don't want to count those failures. | ||
| // when the task backlog decreased. | ||
| client.killExecutors(executorIdsToBeRemoved, adjustTargetNumExecutors = false, | ||
| countFailures = false, force = false) | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: it's