Skip to content

[SPARK-23438][DSTREAMS] Fix DStreams data loss with WAL when driver crashes #20620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gaborgsomogyi wants to merge 3 commits into from
Closed

[SPARK-23438][DSTREAMS] Fix DStreams data loss with WAL when driver crashes #20620

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
152fec4
[SPARK-23438][DSTREAMS] Fix DStreams data loss with WAL when driver c…
gaborgsomogyi Feb 9, 2018
bd46d1c
Fix for empty queue
gaborgsomogyi Feb 15, 2018
23e0204
allocatedBlocks parameter rename
gaborgsomogyi Feb 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix for empty queue
  • Loading branch information
@gaborgsomogyi
gaborgsomogyi committed Feb 15, 2018
commit bd46d1cb63e7a04e0236f7b1bf70b46fb55f3ea4
2 changes: 1 addition & 1 deletion streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceivedBlockTracker.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ private[streaming] class ReceivedBlockTracker(
s"${allocatedBlocks.streamIdToAllocatedBlocks}")
allocatedBlocks.streamIdToAllocatedBlocks.foreach {
case (streamId, allocatedBlocks) =>
Copy link
Member

@viirya viirya Feb 17, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can we use another name (maybe allocatedBlocksInStream?) other than allocatedBlocks to avoid confusion?

Copy link
Contributor Author

@gaborgsomogyi gaborgsomogyi Feb 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, fixed.

streamIdToUnallocatedBlockQueues(streamId).dequeueAll(allocatedBlocks.toSet)
getReceivedBlockQueue(streamId).dequeueAll(allocatedBlocks.toSet)
}
timeToAllocatedBlocks.put(batchTime, allocatedBlocks)
lastAllocatedBatchTime = batchTime
Expand Down