[SPARK-23475][UI] Show also skipped stages #20651
Conversation
|
Test build #87587 has finished for PR 20651 at commit
|
| } | ||
| if (shouldShowSkippedStages) { | ||
| content ++= | ||
| <span id="skipped" class="collapse-aggregated-allSkippedStages collapse-table" |
There was a problem hiding this comment.
I see things like collapse-aggregated-allCompletedStages are mentioned in webui.js, so probably this one should be added there.
This is kinda past the point where this block should be refactored (it's repeated 5 times now), but probably ok for a 2.3 change.
There was a problem hiding this comment.
thanks, I added the UT. I think we can create a new JIRA/followup PR to resolve the code redundancy issue you rightly pointed out, what do you think?
There was a problem hiding this comment.
Sounds good to clean things up in a follow-up.
|
Test build #87615 has finished for PR 20651 at commit
|
|
Jenkins, retest this please |
|
Test build #87617 has finished for PR 20651 at commit
|
|
LGTM, merging to master / 2.3. |
|
Merged to master, but there were conflicts in 2.3; please open a separate PR for the backport. |
|
thanks @vanzin I created the PR for the backport. Thanks. |
SPARK-20648 introduced the status `SKIPPED` for the stages. On the UI, previously, skipped stages were shown as `PENDING`; after this change, they are not shown on the UI. The PR introduce a new section in order to show also `SKIPPED` stages in a proper table. manual tests Author: Marco Gaido <[email protected]> Closes apache#20651 from mgaido91/SPARK-23475.
…code As suggested in #20651, the code is very redundant in `AllStagesPage` and modifying it is a copy-and-paste work. We should avoid such a pattern, which is error prone, and have a cleaner solution which avoids code redundancy. existing UTs Author: Marco Gaido <[email protected]> Closes #20663 from mgaido91/SPARK-23475_followup.
4 participants
What changes were proposed in this pull request?
SPARK-20648 introduced the status
SKIPPEDfor the stages. On the UI, previously, skipped stages were shown asPENDING; after this change, they are not shown on the UI.The PR introduce a new section in order to show also
SKIPPEDstages in a proper table.How was this patch tested?
manual tests