Skip to content

[SPARK-23405] Generate additional constraints for Join's children #20670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KaiXinXiaoLei wants to merge 8 commits into from
Closed

[SPARK-23405] Generate additional constraints for Join's children #20670

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
705ed46
add constranits
huleilei Feb 25, 2018
f44a92a
change code according to review
huleilei Feb 27, 2018
1e0f78a
add test
huleilei Feb 27, 2018
f7d764e
code style
huleilei Feb 27, 2018
b3f2ade
code style
huleilei Feb 28, 2018
ed5c170
change code according to review
huleilei Feb 28, 2018
023f2f7
change code according to review
huleilei Mar 1, 2018
709ed39
add if
huleilei Mar 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add constranits
  • Loading branch information
@huleilei
huleilei committed Feb 25, 2018
commit 705ed462bb307871e65199ce02576f12d60d2176
16 changes: 15 additions & 1 deletion ...yst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/QueryPlanConstraints.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,26 @@ trait QueryPlanConstraints { self: LogicalPlan =>
*/
lazy val constraints: ExpressionSet = {
if (conf.constraintPropagationEnabled) {
Copy link
Contributor

@cloud-fan cloud-fan Feb 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now we don't need this if.

var relevantOutPutSet: AttributeSet = outputSet
constraints.foreach {
case eq @ EqualTo(l: Attribute, r: Attribute) =>
Copy link
Member

@srowen srowen Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eq isn't used

if (l.references.subsetOf(relevantOutPutSet)
Copy link
Member

@srowen srowen Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can avoid computing each subsetOf twice here.

&& !r.references.subsetOf(relevantOutPutSet)) {
relevantOutPutSet = relevantOutPutSet.++(r.references)
Copy link
Member

@srowen srowen Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ++ syntax, rather than write it as a method invocation.

}
if (r.references.subsetOf(relevantOutPutSet)
&& !l.references.subsetOf(relevantOutPutSet)) {
relevantOutPutSet = relevantOutPutSet.++(l.references)
}
case _ => // No inference
}

ExpressionSet(
validConstraints
.union(inferAdditionalConstraints(validConstraints))
.union(constructIsNotNullConstraints(validConstraints))
.filter { c =>
c.references.nonEmpty && c.references.subsetOf(outputSet) && c.deterministic
c.references.nonEmpty && c.references.subsetOf(relevantOutPutSet) && c.deterministic
}
)
} else {
Expand Down