Skip to content

[SPARK-23525] [SQL] Support ALTER TABLE CHANGE COLUMN COMMENT for external hive table #20696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jiangxb1987 wants to merge 3 commits into from
Closed

[SPARK-23525] [SQL] Support ALTER TABLE CHANGE COLUMN COMMENT for external hive table #20696

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92b2f31
support change column comment for external hive table
jiangxb1987 Feb 28, 2018
6035d7e
add test case for change partition column.
jiangxb1987 Mar 1, 2018
48fc338
update error message.
jiangxb1987 Mar 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
update error message.
  • Loading branch information
@jiangxb1987
jiangxb1987 committed Mar 7, 2018
commit 48fc338dc30720aa05e1871d69bad66ae2dfaa59
3 changes: 2 additions & 1 deletion sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,8 @@ case class AlterTableChangeColumnCommand(
schema.fields.collectFirst {
case field if resolver(field.name, name) => field
}.getOrElse(throw new AnalysisException(
s"Invalid column reference '$name', table data schema is '${schema}'"))
s"Can't find column `$name` given table data columns " +
s"${schema.fieldNames.mkString("[`", "`, `", "`]")}"))
}

// Add the comment to a column, if comment is empty, return the original column.
Expand Down
4 changes: 2 additions & 2 deletions sql/core/src/test/resources/sql-tests/results/change-column.sql.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ ALTER TABLE test_change CHANGE invalid_col invalid_col INT
struct<>
-- !query 15 output
org.apache.spark.sql.AnalysisException
Invalid column reference 'invalid_col', table data schema is 'StructType(StructField(a,IntegerType,true), StructField(b,StringType,true), StructField(c,IntegerType,true))';
Can't find column `invalid_col` given table data columns [`a`, `b`, `c`];


-- !query 16
Expand Down Expand Up @@ -296,7 +296,7 @@ ALTER TABLE partition_table CHANGE COLUMN c c INT COMMENT 'this is column C'
struct<>
-- !query 30 output
org.apache.spark.sql.AnalysisException
Invalid column reference 'c', table data schema is 'StructType(StructField(a,IntegerType,true), StructField(b,StringType,true))';
Can't find column `c` given table data columns [`a`, `b`];


-- !query 31
Expand Down