-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-23559][SS] Add epoch ID to DataWriterFactory. #20710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
42bca60
change api
jose-torres 84cfa21
add docs
jose-torres a18a57b
don't use epochId in batch sources
jose-torres b2ee7f3
change comment
jose-torres 55b38db
fix docs
jose-torres 544eb1b
fix docs
jose-torres f5948e8
clarify DataWriter lifecycle
jose-torres 4588616
fix foreach
jose-torres 79495b1
various doc fixes
jose-torres 9fb74e2
describe what's an epoch
jose-torres 215c225
clarify retry docs
jose-torres File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix foreach
- Loading branch information
commit 4588616bea544deb0165986404ccc2918620b8d6
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -186,7 +186,9 @@ object DataWritingSparkTask extends Logging { | |
| try { | ||
| dataWriter = writeTask.createDataWriter( | ||
| context.partitionId(), context.attemptNumber(), currentEpoch) | ||
| iter.foreach(dataWriter.write) | ||
| while (iter.hasNext) { | ||
| dataWriter.write(iter.next()) | ||
| } | ||
| logInfo(s"Writer for partition ${context.partitionId()} is committing.") | ||
| val msg = dataWriter.commit() | ||
| logInfo(s"Writer for partition ${context.partitionId()} committed.") | ||
|
|
@@ -199,7 +201,8 @@ object DataWritingSparkTask extends Logging { | |
| // Continuous shutdown always involves an interrupt. Just finish the task. | ||
| } | ||
| })(catchBlock = { | ||
| // If there is an error, abort this writer | ||
| // If there is an error, abort this writer. We enter this callback in the middle of | ||
| // rethrowing an exception, so runContinuous will stop executing at this point. | ||
| logError(s"Writer for partition ${context.partitionId()} is aborting.") | ||
| if (dataWriter != null) dataWriter.abort() | ||
| logError(s"Writer for partition ${context.partitionId()} aborted.") | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: add comment that the exception will be rethrown. |
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason to change
foreachto a while loop?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC (/cc @tdas) foreach can be problematic in tight loops, because it introduces a lambda that isn't always optimized away.