Skip to content

Conversation

@juliuszsompolski
Copy link
Contributor

What changes were proposed in this pull request?

In #20679 I missed a few places in SQL tests.
For hygiene, they should also use the sessionState interface where possible.

How was this patch tested?

Modified existing tests.

@juliuszsompolski
Copy link
Contributor Author

cc @gatorsmile

@juliuszsompolski
Copy link
Contributor Author

jenkins retest this please
hudson.plugins.git.GitException: Failed to fetch from https://github.com/apache/spark.git

Copy link
Member

@gatorsmile gatorsmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending Jenkins

@SparkQA
Copy link

SparkQA commented Mar 2, 2018

Test build #87893 has finished for PR 20718 at commit 358a76a.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@juliuszsompolski
Copy link
Contributor Author

jenkins retest this please

org.apache.spark.sql.FileBasedDataSourceSuite.(It is not a test it is a sbt.testing.SuiteSelector)

org.scalatest.exceptions.TestFailedDueToTimeoutException: The code passed to eventually never returned normally. Attempted 15 times over 10.014418413000001 seconds. Last failure message: There are 1 possibly leaked file streams..

Could be a problem, but I don't see how it's related.

@juliuszsompolski
Copy link
Contributor Author

jenkins retest this please

@SparkQA
Copy link

SparkQA commented Mar 2, 2018

Test build #87902 has finished for PR 20718 at commit 358a76a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

thanks, merging to master!

@asfgit asfgit closed this in dea381d Mar 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants