[SPARK-23568][ML] Use metadata numAttributes if available in Silhouette #20719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #87895 has finished for PR 20719 at commit
|
|
Test build #88151 has finished for PR 20719 at commit
|
srowen
approved these changes
Mar 18, 2018
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
I'm not so familiar with this, but it looks logical
viirya
reviewed
Mar 19, 2018
|
|
||
| protected def getNumberOfFeatures(dataFrame: DataFrame, columnName: String): Int = { | ||
| val group = AttributeGroup.fromStructField(dataFrame.schema(columnName)) | ||
| group.numAttributes.getOrElse { |
Member
There was a problem hiding this comment.
We should use size of AttributeGroup to determine its number of attributes. When it is -1, we can leverage first then.
|
Test build #88375 has finished for PR 20719 at commit
|
Member
|
Merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Silhouette need to know the number of features. This was taken using
firstand checking the size of the vector. Despite this works fine, if the number of attributes is present in metadata, we can avoid to trigger a job for this and use the metadata value. This can help improving performances of course.How was this patch tested?
existing UTs + added UT