Skip to content

[SPARK-18630][PYTHON][ML] Move del method from JavaParams to JavaWrapper; add tests #20724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yogeshg wants to merge 3 commits into from
Closed

[SPARK-18630][PYTHON][ML] Move del method from JavaParams to JavaWrapper; add tests #20724

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
50acecc
add test case for JavaWrapper that displays memory leak for JavaWrapp…
Mar 3, 2018
d36c1a1
send the delete method from JavaParams to JavaWrapper
Mar 3, 2018
07e1829
fix style
Mar 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
send the delete method from JavaParams to JavaWrapper
  • Loading branch information
Yogesh Garg committed Mar 3, 2018
commit d36c1a10cd318d9ddeb2717737248c974a2349f1
8 changes: 4 additions & 4 deletions python/pyspark/ml/wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ def __init__(self, java_obj=None):
super(JavaWrapper, self).__init__()
self._java_obj = java_obj

def __del__(self):
if SparkContext._active_spark_context and not self._java_obj is None:
SparkContext._active_spark_context._gateway.detach(self._java_obj)

@classmethod
def _create_from_java_class(cls, java_class, *args):
"""
Expand Down Expand Up @@ -100,10 +104,6 @@ class JavaParams(JavaWrapper, Params):

__metaclass__ = ABCMeta

def __del__(self):
if SparkContext._active_spark_context:
SparkContext._active_spark_context._gateway.detach(self._java_obj)

def _make_java_param_pair(self, param, value):
"""
Makes a Java param pair.
Expand Down