[SPARK-23594][SQL] GetExternalRowField should support interpreted execution #20746
Conversation
|
Test build #87995 has finished for PR 20746 at commit
|
|
retest this please |
|
|
||
| // If an input row or a field are null, a runtime exception will be thrown | ||
| val errMsg1 = intercept[RuntimeException] { | ||
| evaluate(getRowField, InternalRow.fromSeq(Seq(null))) |
There was a problem hiding this comment.
Minor comment: This only tests the interpreted code path. Maybe we should add something to the ExpressionEvalHelper harness to test all paths in case of failure. Let me know if you want to pick this up, we can also spin that off into a separate PR.
There was a problem hiding this comment.
Aha, sound nice to me. Would it be better to add the helper function first before this pr?
There was a problem hiding this comment.
Let's just merge this, and add the helper in a follow-up.
There was a problem hiding this comment.
I have created https://issues.apache.org/jira/browse/SPARK-23611 to track this.
There was a problem hiding this comment.
ok, thanks! I'll make a pr later for that.
|
@maropu look pretty good. I left one comment, otherwise this is gtg. |
|
Test build #87997 has finished for PR 20746 at commit
|
|
Merging to master. Thanks! |
3 participants
What changes were proposed in this pull request?
This pr added interpreted execution for
GetExternalRowField.How was this patch tested?
Added tests in
ObjectExpressionsSuite.