Skip to content
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
initial commit
  • Loading branch information
kiszk committed Mar 9, 2018
commit e206fffb0bb529f7cb030f6744ae97346cc0ca18
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public long durationMs() {
/**
* Append a row to currentRows.
*/
protected void append(InternalRow row) {
public void append(InternalRow row) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Although we added the test, should we also add a short sentence that said this is public so inner classes can also access it?

currentRows.add(row);
}

Expand All @@ -75,7 +75,7 @@ protected void append(InternalRow row) {
* If it returns true, the caller should exit the loop that [[InputAdapter]] generates.
* This interface is mainly used to limit the number of input rows.
*/
protected boolean stopEarly() {
public boolean stopEarly() {
return false;
}

Expand All @@ -84,14 +84,14 @@ protected boolean stopEarly() {
*
* If it returns true, the caller should exit the loop (return from processNext()).
*/
protected boolean shouldStop() {
public boolean shouldStop() {
return !currentRows.isEmpty();
}

/**
* Increase the peak execution memory for current task.
*/
protected void incPeakExecutionMemory(long size) {
public void incPeakExecutionMemory(long size) {
TaskContext.get().taskMetrics().incPeakExecutionMemory(size);
}

Expand Down