Skip to content

[SPARK-23637][YARN]Yarn might allocate more resource if a same executor is killed multiple times. #20781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jinxing64 wants to merge 3 commits into from
Closed

[SPARK-23637][YARN]Yarn might allocate more resource if a same executor is killed multiple times. #20781

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd6f8a1
[SPARK-23637][YARN]Yarn might allocate more resource if a same execut…
Mar 9, 2018
a177a63
it's possible that YarnAllocator process same completed container mul…
Mar 9, 2018
049ed49
Use runningExecutors as a set.
Mar 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use runningExecutors as a set.
  • Loading branch information
jinxing committed Mar 12, 2018
commit 049ed495bb8c7da05f034300237cf9360bc0848d
5 changes: 3 additions & 2 deletions resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@ private[yarn] class YarnAllocator(
private val releasedContainers = Collections.newSetFromMap[ContainerId](
new ConcurrentHashMap[ContainerId, java.lang.Boolean])

private val runningExecutors = new java.util.concurrent.ConcurrentHashMap[String, Unit]()
private val runningExecutors = Collections.newSetFromMap[String](
new ConcurrentHashMap[String, java.lang.Boolean]())

private val numExecutorsStarting = new AtomicInteger(0)

Expand Down Expand Up @@ -501,7 +502,7 @@ private[yarn] class YarnAllocator(
s"for executor with ID $executorId")

def updateInternalState(): Unit = synchronized {
runningExecutors.put(executorId, Unit)
runningExecutors.add(executorId)
numExecutorsStarting.decrementAndGet()
executorIdToContainer(executorId) = container
containerIdToExecutorId(container.getId) = executorId
Expand Down