Skip to content

[SPARK-23486]cache the function name from the external catalog for lookupFunctions #20795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kevinyu98 wants to merge 12 commits into from
Closed

[SPARK-23486]cache the function name from the external catalog for lookupFunctions #20795

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5c8648c
cache the function name from the catalog for lookupFunction
kevinyu98 Mar 11, 2018
caf6b6d
address comments and add test cases
kevinyu98 Mar 13, 2018
b8871e2
commit the new testcase file
kevinyu98 Mar 13, 2018
14c62e4
add normalize during function name lookup
kevinyu98 Mar 16, 2018
5c6687c
just cache external function name
kevinyu98 Mar 19, 2018
e030bd0
fix the HiveSQLViewSuite failure
kevinyu98 Mar 21, 2018
6358b92
address comments
kevinyu98 Mar 26, 2018
74b01a5
changing the APIs in SessionCatalog
kevinyu98 Apr 10, 2018
27246fb
address comments
kevinyu98 Jul 10, 2018
8dceda9
fix style
kevinyu98 Jul 11, 2018
0db2826
add isRegisteredFunction check
kevinyu98 Jul 12, 2018
26f2f54
check case sensitive
kevinyu98 Jul 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix the HiveSQLViewSuite failure
  • Loading branch information
@kevinyu98
kevinyu98 committed Jul 10, 2018
commit e030bd014057ad520390936f63542d9a212a63ac
2 changes: 2 additions & 0 deletions sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,8 @@ private[sql] class HiveSessionCatalog(
super.functionExists(name) || hiveFunctions.contains(name.funcName)
}

override def externalFunctionExists(name: FunctionIdentifier): Boolean = functionExists(name)
Copy link
Contributor

@WeichenXu123 WeichenXu123 Mar 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to your logic, I think HiveSessionCatalog should override both buildinFunctionExists and externalFunctionExists. Like:

override def buildinFunctionExists(name: FunctionIdentifier): Boolean = {
   super.buildinFunctionExists(name) || hiveFunctions.contains(name.funcName)
}
override def externalFunctionExists(name: FunctionIdentifier): Boolean = functionExists(name) = {
  super.externalFunctionExists(name)
}

Copy link
Contributor Author

@kevinyu98 kevinyu98 Mar 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WeichenXu123 thanks very much for reviewing. I am a little confused. So HiveSessionCatalog's builtinFunctionExists is essentially same as its parent. That is the reason i didn't override it in HiveSessionCatalog. However the logic to lookup an external function is different in HiveSessionCatalog as we also have to handle the special function "histogram_numeric". Thats why i choose to override the externalFunctionExists. One clarification is that builtinFunctionExists solely looks at FunctionRegistry to lookup a function.

  1. builtInFunctionExists => Looks up a function in FunctionRegistry (same for both SessionCatalog and HiveSessionCatalog
  2. externalFunctionExists => Looks up an external catalog to find the function. HiveSessionCatalog has one additional semantics to handle the special function called histogram_numeric.
  3. as you point out, I need to change the override externalFunctionExists to this:
    override def externalFunctionExists(name: FunctionIdentifier): Boolean = { super.externalFunctionExists(name) || hiveFunctions.contains(name.funcName)

Copy link
Contributor

@WeichenXu123 WeichenXu123 Mar 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you mean functions like "histogram_numeric" should be regarded as externalFunction in hiveContext ? I am not sure about this. But if that's right your current code is OK :)

Copy link
Contributor Author

@kevinyu98 kevinyu98 Mar 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, seem "histogram_numeric" is not supported in spark natively yet, I think once this jira closed (https://issues.apache.org/jira/browse/SPARK-16280), we don't need these codes in the HiveSessionCatalog.


/** List of functions we pass over to Hive. Note that over time this list should go to 0. */
// We have a list of Hive built-in functions that we do not support. So, we will check
// Hive's function registry and lazily load needed functions into our own function registry.
Expand Down