Skip to content

[SPARK-23668][K8S] Add config option for passing through k8s Pod.spec.imagePullSecrets #20811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrusha wants to merge 6 commits into from
Closed

[SPARK-23668][K8S] Add config option for passing through k8s Pod.spec.imagePullSecrets #20811

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e3a50be
Add config option for passing through k8s Pod.spec.imagePullSecrets
Mar 13, 2018
4b8b39a
Address review comments
Mar 23, 2018
c13ee6c
Fix import styling in /BasicDriverConfigurationStepSuite.scala
Apr 3, 2018
4173977
Rename imagePullSecret to match image.pullPolicy
andrusha Apr 3, 2018
c8fb9fa
Allow multiple imagePullSecrets
Apr 4, 2018
0291f0f
Fix comment indentation style
andrusha Apr 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename imagePullSecret to match image.pullPolicy
  • Loading branch information
@andrusha
andrusha committed Apr 3, 2018
commit 4173977e0435a2e7d62f03af79f15c90a1b0689e
2 changes: 1 addition & 1 deletion resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ private[spark] object Config extends Logging {
.createWithDefault("IfNotPresent")

val IMAGE_PULL_SECRET =
ConfigBuilder("spark.kubernetes.imagePullSecret")
ConfigBuilder("spark.kubernetes.container.image.pullSecret")
Copy link
Contributor

@foxish foxish Apr 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on a conversation with the node team, this is meant to be an array of possibly many secret names; since one could have multiple secrets specified for different registries and spread across multiple k8s secrets.

So, I'd suggest we implement the full API - this should be capable of accepting a comma separated list of one or more secret names.

Copy link
Contributor

@foxish foxish Apr 3, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also should be named ...image.pullSecrets to stay consistent with the field we're setting on the pods.

Copy link
Contributor Author

@andrusha andrusha Apr 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@foxish done

.doc("Specifies the Kubernetes secret used to access private image registry.")
.stringConf
.createOptional
Expand Down