Skip to content

[SPARK-23743][SQL] Changed a comparison logic from containing 'slf4j' to starting with 'org.slf4j' #20860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jongyoul wants to merge 2 commits into from
Closed

[SPARK-23743][SQL] Changed a comparison logic from containing 'slf4j' to starting with 'org.slf4j' #20860

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
192ce30
Changed a comparison logic from containing 'slf4j' to starting with '…
jongyoul Mar 20, 2018
2ea9b7a
Changed a comparison logic from containing 'log4j' to starting with '…
jongyoul Mar 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Changed a comparison logic from containing 'slf4j' to starting with '… 
…org.slf4j'
  • Loading branch information
@jongyoul
jongyoul committed Mar 20, 2018
commit 192ce305f05d4280c5c35b94a3666d313dab2733
2 changes: 1 addition & 1 deletion sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ private[hive] class IsolatedClientLoader(
val isHadoopClass =
name.startsWith("org.apache.hadoop.") && !name.startsWith("org.apache.hadoop.hive.")

name.contains("slf4j") ||
name.startsWith("org.slf4j") ||
name.contains("log4j") ||
Copy link
Member

@felixcheung felixcheung Mar 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need the same for "log4j"?

Copy link
Member Author

@jongyoul jongyoul Mar 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, It looks like a similar issue. I'll add it.

Copy link
Member Author

@jongyoul jongyoul Mar 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

name.startsWith("org.apache.spark.") ||
(sharesHadoopClasses && isHadoopClass) ||
Expand Down