Skip to content

[SPARK-23765][SQL] Supports custom line separator for json datasource #20877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HyukjinKwon wants to merge 3 commits into from
Closed

[SPARK-23765][SQL] Supports custom line separator for json datasource #20877

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c674f4a
Supports line separator for json datasource
HyukjinKwon Mar 3, 2018
6cbf1ac
Consistent variable name
HyukjinKwon Mar 22, 2018
f5e7d34
Address a comment
HyukjinKwon Mar 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Address a comment
  • Loading branch information
@HyukjinKwon
HyukjinKwon committed Mar 25, 2018
commit f5e7d34d0e422789fdd979a6a17ee7f48b77d0be
14 changes: 14 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2113,4 +2113,18 @@ class JsonSuite extends QueryTest with SharedSQLContext with TestJsonData {
testLineSeparator(lineSep)
}
// scalastyle:on nonascii

test("""SPARK-21289: Support line separator - default value \r, \r\n and \n""") {
val data =
"{\"f\": \"a\", \"f0\": 1}\r{\"f\": \"c\", \"f0\": 2}\r\n{\"f\": \"d\", \"f0\": 3}\n"

withTempPath { path =>
Files.write(path.toPath, data.getBytes(StandardCharsets.UTF_8))
val df = spark.read.json(path.getAbsolutePath)
val expectedSchema =
StructType(StructField("f", StringType) :: StructField("f0", LongType) :: Nil)
checkAnswer(df, Seq(("a", 1), ("c", 2), ("d", 3)).toDF())
assert(df.schema === expectedSchema)
}
}
}