[MINOR][R] Fix R lint failure #20879
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @felixcheung and @shaneknapp |
|
Test build #88519 has finished for PR 20879 at commit
|
Contributor
|
i've had to punt on figuring out how to get spark to reliably build across branches on the ubuntu workers... mostly because i haven't been able to successfully get the proper versions of various R packages installed that mirror what's on the old and barely touched centos workers. |
Contributor
|
other than that, this PR LGTM++ |
Member
|
thanks! those are on me then. |
felixcheung
approved these changes
Mar 23, 2018
Member
Author
|
Yup, we are running old lint in PR builders and those are on the newer one. |
asfgit
pushed a commit
that referenced
this pull request
Mar 23, 2018
## What changes were proposed in this pull request?
The lint failure bugged me:
```R
R/SQLContext.R:715:97: style: Trailing whitespace is superfluous.
#' file-based streaming data source. \code{timeZone} to indicate a timezone to be used to
^
tests/fulltests/test_streaming.R:239:45: style: Commas should always have a space after.
expect_equal(times[order(times$eventTime),][1, 2], 2)
^
lintr checks failed.
```
and I actually saw https://amplab.cs.berkeley.edu/jenkins/job/spark-master-test-sbt-hadoop-2.6-ubuntu-test/500/console too. If I understood correctly, there is a try about moving to Unbuntu one.
## How was this patch tested?
Manually tested by `./dev/lint-r`:
```
...
lintr checks passed.
```
Author: hyukjinkwon <[email protected]>
Closes #20879 from HyukjinKwon/minor-r-lint.
(cherry picked from commit 92e9525)
Signed-off-by: hyukjinkwon <[email protected]>
Member
Author
|
Merged to master and branch-2.3. Thanks for reviewing this @shaneknapp and @felixcheung. |
peter-toth
pushed a commit
to peter-toth/spark
that referenced
this pull request
Oct 6, 2018
## What changes were proposed in this pull request?
The lint failure bugged me:
```R
R/SQLContext.R:715:97: style: Trailing whitespace is superfluous.
#' file-based streaming data source. \code{timeZone} to indicate a timezone to be used to
^
tests/fulltests/test_streaming.R:239:45: style: Commas should always have a space after.
expect_equal(times[order(times$eventTime),][1, 2], 2)
^
lintr checks failed.
```
and I actually saw https://amplab.cs.berkeley.edu/jenkins/job/spark-master-test-sbt-hadoop-2.6-ubuntu-test/500/console too. If I understood correctly, there is a try about moving to Unbuntu one.
## How was this patch tested?
Manually tested by `./dev/lint-r`:
```
...
lintr checks passed.
```
Author: hyukjinkwon <[email protected]>
Closes apache#20879 from HyukjinKwon/minor-r-lint.
(cherry picked from commit 92e9525)
Signed-off-by: hyukjinkwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The lint failure bugged me:
and I actually saw https://amplab.cs.berkeley.edu/jenkins/job/spark-master-test-sbt-hadoop-2.6-ubuntu-test/500/console too. If I understood correctly, there is a try about moving to Unbuntu one.
How was this patch tested?
Manually tested by
./dev/lint-r: