[MINOR][CORE] Renamed long URL with shortened version #20882
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Contributor
Author
|
This change has been included in #20880 so a separate PR isn't necessary for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We found that Scalastyle was disabled in
BlockReplicationPolicy.scalabecause there was a URL in there that caused the line length to be exceeded. The URL was to astackexchange.comsite which actually accepts shortened versions of their normal URL as well. So we could replace the URL with the officially supported shortened version and enable Scalastyle again since this no longer exceeds the line length. I also changed the URL fromhttptohttpssince the site automatically redirects tohttpsanyway.How was this patch tested?
We tested this by running
./dev/lint-scala. First we ran it with the long URL to ensure that it actually detects the violation. Then we changed this to the shortened URL and ran it again. This time it saidScalastyle checks passed.Co-contributors:
@chialun-yeh
@Hrayo712
@vpourquie