[SPARK-23792][DOCS] Documentation improvements for datetime functions #20901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
ok to test |
Member
|
mind resolving the conflicts? |
Contributor
Author
|
@HyukjinKwon, merge conflicts have now been resolved |
|
Test build #91606 has finished for PR 20901 at commit
|
|
Test build #91620 has finished for PR 20901 at commit
|
srowen
approved these changes
Aug 25, 2018
|
Test build #4291 has finished for PR 20901 at commit
|
Member
|
The failure isn't related: (There has never been a checkstyle-config.xml in the project) |
|
Test build #4292 has finished for PR 20901 at commit
|
Member
|
Merged to master |
bogdanrdc
pushed a commit
to bogdanrdc/spark
that referenced
this pull request
Aug 28, 2018
## What changes were proposed in this pull request? Improved the documentation for the datetime functions in `org.apache.spark.sql.functions` by adding details about the supported column input types, the column return type, behaviour on invalid input, supporting examples and clarifications. ## How was this patch tested? Manually testing each of the datetime functions with different input to ensure that the corresponding Javadoc/Scaladoc matches the behaviour of the function. Successfully ran the `unidoc` SBT process. Closes apache#20901 from abradbury/SPARK-23792. Authored-by: Adam Bradbury <[email protected]> Signed-off-by: Sean Owen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Improved the documentation for the datetime functions in
org.apache.spark.sql.functionsby adding details about the supported column input types, the column return type, behaviour on invalid input, supporting examples and clarifications.How was this patch tested?
Manually testing each of the datetime functions with different input to ensure that the corresponding Javadoc/Scaladoc matches the behaviour of the function. Successfully ran the
unidocSBT process.