[SPARK-23599][SQL][Backport-2.3] Use RandomUUIDGenerator in Uuid expression #20903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
commented
Mar 26, 2018
|
|
||
| val seed2 = Some(r.nextLong()) | ||
| val uuid2 = evaluate(Uuid(seed2)).asInstanceOf[UTF8String] | ||
| assertIncorrectEval(() => checkEvaluationWithoutCodegen(Uuid(seed1), uuid2)) |
Member
Author
There was a problem hiding this comment.
The methods like evaluateWithGeneratedMutableProjection seems not available in 2.3 branch. Currently I choose not to add too much change to ExpressionEvalHelper for this backport. So here I just call checkEvaluationXXX methods and expect exception with expected error message.
|
Test build #88582 has finished for PR 20903 at commit
|
Member
Author
|
retest this please. |
|
Test build #88587 has finished for PR 20903 at commit
|
Contributor
|
Merging to 2.3. Thanks! Can you close? |
asfgit
pushed a commit
that referenced
this pull request
Mar 26, 2018
…ession ## What changes were proposed in this pull request? As stated in Jira, there are problems with current `Uuid` expression which uses `java.util.UUID.randomUUID` for UUID generation. This patch uses the newly added `RandomUUIDGenerator` for UUID generation. So we can make `Uuid` deterministic between retries. This backports SPARK-23599 to Spark 2.3. ## How was this patch tested? Added tests. Author: Liang-Chi Hsieh <[email protected]> Closes #20903 from viirya/SPARK-23599-2.3.
Member
Author
|
Thanks! @hvanhovell |
peter-toth
pushed a commit
to peter-toth/spark
that referenced
this pull request
Oct 6, 2018
…ession As stated in Jira, there are problems with current `Uuid` expression which uses `java.util.UUID.randomUUID` for UUID generation. This patch uses the newly added `RandomUUIDGenerator` for UUID generation. So we can make `Uuid` deterministic between retries. This backports SPARK-23599 to Spark 2.3. Added tests. Author: Liang-Chi Hsieh <[email protected]> Closes apache#20903 from viirya/SPARK-23599-2.3. Change-Id: I9b9e1b78e7ab527aa4d8fd8cdd1d0cf0942e5645
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As stated in Jira, there are problems with current
Uuidexpression which usesjava.util.UUID.randomUUIDfor UUID generation.This patch uses the newly added
RandomUUIDGeneratorfor UUID generation. So we can makeUuiddeterministic between retries.This backports SPARK-23599 to Spark 2.3.
How was this patch tested?
Added tests.