Skip to content

[SPARK-23802][SQL] PropagateEmptyRelation can leave query plan in unresolved state #20914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robert3005 wants to merge 6 commits into from
Closed

[SPARK-23802][SQL] PropagateEmptyRelation can leave query plan in unresolved state #20914

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8cac372
cast
Mar 12, 2018
6b9c45d
it actually works
Mar 27, 2018
2b02cb7
propagate empty fix
Mar 27, 2018
d9a2ee8
typo
Mar 27, 2018
cd96401
fix other tests
Mar 29, 2018
1c123bd
use cast support
Mar 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
cast
  • Loading branch information
Robert Kruszewski committed Mar 29, 2018
commit 8cac372f0f9ba3b321cb95c0ecae925aee60a07c
2 changes: 1 addition & 1 deletion ...alyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/PropagateEmptyRelation.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ object PropagateEmptyRelation extends Rule[LogicalPlan] with PredicateHelper {

// Construct a project list from plan's output, while the value is always NULL.
private def nullValueProjectList(plan: LogicalPlan): Seq[NamedExpression] =
plan.output.map{ a => Alias(Literal(null), a.name)(a.exprId) }
plan.output.map{ a => Alias(Cast(Literal(null), a.dataType), a.name)(a.exprId) }
Copy link
Member

@gatorsmile gatorsmile Mar 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use CastSupport.cast


def apply(plan: LogicalPlan): LogicalPlan = plan transformUp {
case p: Union if p.children.forall(isEmptyLocalRelation) =>
Expand Down