[SPARK-19964][core] Avoid reading from remote repos in SparkSubmitSuite. #20916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests can fail with a timeout if the remote repos are not responding, or slow. The tests don't need anything from those repos, so use an empty ivy config file to avoid setting up the defaults. The tests are passing reliably for me locally now, and failing more often than not today without this change since http://dl.bintray.com/spark-packages/maven doesn't seem to be loading from my machine.
|
Test build #88637 has finished for PR 20916 at commit
|
felixcheung
approved these changes
Mar 29, 2018
HyukjinKwon
reviewed
Apr 2, 2018
| // Necessary to make ScalaTest 3.x interrupt a thread on the JVM like ScalaTest 2.2.x | ||
| implicit val defaultSignaler: Signaler = ThreadSignaler | ||
|
|
||
| private val emptyIvySettings = File.createTempFile("ivy", ".xml") |
Member
There was a problem hiding this comment.
@vanzin, do we need to delete this back after the tests?
Contributor
Author
There was a problem hiding this comment.
It's not necessary to delete temp files in tests. They'll go away when you do a "clean".
HyukjinKwon
approved these changes
Apr 2, 2018
Member
HyukjinKwon
left a comment
HyukjinKwon
left a comment
There was a problem hiding this comment.
LGTM except one a nit(?) or question
asfgit
pushed a commit
that referenced
this pull request
Apr 3, 2018
These tests can fail with a timeout if the remote repos are not responding, or slow. The tests don't need anything from those repos, so use an empty ivy config file to avoid setting up the defaults. The tests are passing reliably for me locally now, and failing more often than not today without this change since http://dl.bintray.com/spark-packages/maven doesn't seem to be loading from my machine. Author: Marcelo Vanzin <[email protected]> Closes #20916 from vanzin/SPARK-19964. (cherry picked from commit 441d0d0) Signed-off-by: hyukjinkwon <[email protected]>
Member
|
Merged to master and branch-2.3. |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Apr 4, 2018
These tests can fail with a timeout if the remote repos are not responding, or slow. The tests don't need anything from those repos, so use an empty ivy config file to avoid setting up the defaults. The tests are passing reliably for me locally now, and failing more often than not today without this change since http://dl.bintray.com/spark-packages/maven doesn't seem to be loading from my machine. Author: Marcelo Vanzin <[email protected]> Closes apache#20916 from vanzin/SPARK-19964.
mshtelma
pushed a commit
to mshtelma/spark
that referenced
this pull request
Apr 5, 2018
These tests can fail with a timeout if the remote repos are not responding, or slow. The tests don't need anything from those repos, so use an empty ivy config file to avoid setting up the defaults. The tests are passing reliably for me locally now, and failing more often than not today without this change since http://dl.bintray.com/spark-packages/maven doesn't seem to be loading from my machine. Author: Marcelo Vanzin <[email protected]> Closes apache#20916 from vanzin/SPARK-19964.
peter-toth
pushed a commit
to peter-toth/spark
that referenced
this pull request
Oct 6, 2018
These tests can fail with a timeout if the remote repos are not responding, or slow. The tests don't need anything from those repos, so use an empty ivy config file to avoid setting up the defaults. The tests are passing reliably for me locally now, and failing more often than not today without this change since http://dl.bintray.com/spark-packages/maven doesn't seem to be loading from my machine. Author: Marcelo Vanzin <[email protected]> Closes apache#20916 from vanzin/SPARK-19964. (cherry picked from commit 441d0d0) Signed-off-by: hyukjinkwon <[email protected]> Change-Id: Icf3562701b9108c9132745d8a8971a979d72da8c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests can fail with a timeout if the remote repos are not responding,
or slow. The tests don't need anything from those repos, so use an empty
ivy config file to avoid setting up the defaults.
The tests are passing reliably for me locally now, and failing more often
than not today without this change since http://dl.bintray.com/spark-packages/maven
doesn't seem to be loading from my machine.