Skip to content

[SPARK-23819][SQL] Fix InMemoryTableScanExec complex type pruning #20935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pwoody wants to merge 6 commits into from
Closed

[SPARK-23819][SQL] Fix InMemoryTableScanExec complex type pruning #20935

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
83e1e53
SPARK-23819: InMemoryTableScanExec prunes orderable complex types due…
Mar 29, 2018
5c95cef
Fix null types
Mar 29, 2018
a63eb59
Merge branch 'master' of https://github.com/apache/spark
Mar 30, 2018
426374b
Add copying for unsafe data structures
Mar 31, 2018
1479bde
pr feedback
Apr 1, 2018
6ea0919
extra test make Map orderable safe
Apr 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix null types
  • Loading branch information
Patrick Woody committed Mar 29, 2018
commit 5c95cef81257185205c7ecebe3353060780b2c52
8 changes: 4 additions & 4 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/ColumnStats.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,10 +328,10 @@ private[columnar] final class ObjectColumnStats(dataType: DataType) extends Colu
protected var lower: Any = null

val columnType = ColumnType(dataType)
val ordering = if (RowOrdering.isOrderable(dataType)) {
Option(TypeUtils.getInterpretedOrdering(dataType))
} else {
None
val ordering = dataType match {
case x if RowOrdering.isOrderable(dataType) && x != NullType =>
Option(TypeUtils.getInterpretedOrdering(x))
case _ => None
Copy link
Member

@viirya viirya Mar 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this class is only for "orderable", maybe we don't need optional here and ordering can just be Ordering[T].

Copy link
Author

@pwoody pwoody Mar 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for DataTypes that could be orderable since Arrays and Structs may have children data types that aren't.

}

override def gatherStats(row: InternalRow, ordinal: Int): Unit = {
Expand Down