Skip to content

[SPARK-23827] [SS] StreamingJoinExec should ensure that input data is partitioned into specific number of partitions #20941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tdas wants to merge 5 commits into from
Closed

[SPARK-23827] [SS] StreamingJoinExec should ensure that input data is partitioned into specific number of partitions #20941

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
02cc550
Fixed join issue
tdas Mar 29, 2018
7046fbd
Fix compilation
tdas Mar 29, 2018
c162f8d
Removed unnecessary tests
tdas Mar 29, 2018
555eeb3
Addressed comments
tdas Mar 30, 2018
aeec843
Added null checks to avoid flakiness
tdas Mar 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/IncrementalExecution.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ class IncrementalExecution(
StreamingDeduplicationStrategy :: Nil
}

private val numStateStores = offsetSeqMetadata.conf.get(SQLConf.SHUFFLE_PARTITIONS.key)
private[sql] val numStateStores = offsetSeqMetadata.conf.get(SQLConf.SHUFFLE_PARTITIONS.key)
.map(SQLConf.SHUFFLE_PARTITIONS.valueConverter)
.getOrElse(sparkSession.sessionState.conf.numShufflePartitions)

Expand Down
4 changes: 2 additions & 2 deletions sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,8 +450,8 @@ trait StreamTest extends QueryTest with SharedSQLContext with TimeLimits with Be
// This can often catch hard to debug errors when developing stateful operators
val executedPlan = currentStream.lastExecution.executedPlan
executedPlan.collect { case s: StatefulOperator => s }.foreach { s =>
assert(s.stateInfo.isDefined)
assert(s.stateInfo.get.numPartitions >= 1)
assert(
s.stateInfo.map(_.numPartitions).contains(currentStream.lastExecution.numStateStores))
Copy link
Contributor

@brkyvz brkyvz Mar 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change?


s.requiredChildDistribution.foreach { d =>
withClue(s"$s specifies incorrect # partitions in requiredChildDistribution $d") {
Expand Down